Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dekorate as an imported BOM #580

Closed
wants to merge 2 commits into from
Closed

Add Dekorate as an imported BOM #580

wants to merge 2 commits into from

Conversation

alvarosanchez
Copy link
Member

@alvarosanchez
Copy link
Member Author

@melix I noticed that this generates:

<dependency>
    <groupId>io.dekorate</groupId>
    <artifactId>dekorate-bom</artifactId>
    <version>${dekorate.version}</version>
    <type>pom</type>
    <scope>import</scope>
</dependency>

However there is no such dekorate.version property:

<properties>
    <micronaut.kubernetes.version>5.0.0-M2</micronaut.kubernetes.version>
</properties>

What am I missing?

@melix
Copy link

melix commented Jun 2, 2023

You should make the dekorate version managed (use managed-dekorate instead of dekorate). Is dekorate specific to this project? Or should it live in micronaut-kotlin?

@alvarosanchez
Copy link
Member Author

You should make the dekorate version managed (use managed-dekorate instead of dekorate).

🤦 thanks

Is dekorate specific to this project? Or should it live in micronaut-kotlin?

Belongs here. The K stands for Kubernetes, not Kotlin

@alvarosanchez
Copy link
Member Author

Blocked by dekorateio/dekorate#1207

@melix is there any workaround for this problem meanwhile?

@alvarosanchez alvarosanchez marked this pull request as draft June 2, 2023 10:57
@melix
Copy link

melix commented Jun 2, 2023

I am not sure there would be a solution which would let the version take precedence, especially for both Maven and Gradle :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants