Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DekorateSpec fails #1854

Open
wants to merge 2 commits into
base: 4.0.x
Choose a base branch
from
Open

DekorateSpec fails #1854

wants to merge 2 commits into from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jun 6, 2023

No description provided.

@timyates
Copy link
Contributor

timyates commented Jun 6, 2023

Ok, so dekorate used to be a managed dependency and version in the core pom

This is no longer true...

I will add it as a version here

@timyates
Copy link
Contributor

timyates commented Jun 6, 2023

Ok, so the old version we used to use (1.0.3) had issues with versions, so the generated YAML was infact invalid and contained stuff like

        image: tim/foo:"0.1"

So I bumped it up to 3.6.1 (the latest)

However they dropped io.dekorate:servicecatalog-annotations and io.dekorate:halkyon-annotations before they released v2, and for some reason jaeger is failing...

If you agree, I suggest we:

  1. Drop the service-catalog and halkyon features for 4.0.0
  2. Work out how to fix jaeger

@timyates
Copy link
Contributor

timyates commented Jun 6, 2023

@alvarosanchez ☝️ I know you've been working with Kubernetes, does this seem sensible? Do you use dekorate in any of your demos?

@alvarosanchez
Copy link
Member

Here's a demo of Dekorate v3 with Micronaut 3.9: https://github.com/alvarosanchez/micronaut-kubernetes-demo

Note that Dekorate has been removed from Platform because it really belongs to Micronaut Kubernetes. There is an open PR which is currently blocked by a pending new release.

@timyates timyates added the status: awaiting third-party Awaiting changes to a third party library label Jun 7, 2023
@timyates
Copy link
Contributor

timyates commented Jun 7, 2023

We will wait for micronaut-projects/micronaut-kubernetes#580 to fix this up here

@timyates
Copy link
Contributor

@alvarosanchez any update?

@alvarosanchez
Copy link
Member

I noticed that 3.7.0 has the missing artifact, so I've created micronaut-projects/micronaut-kubernetes#598

@alvarosanchez
Copy link
Member

Now blocked by dekorateio/dekorate#1231 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting third-party Awaiting changes to a third party library
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants