cleanup test projects #2363
Merged
cleanup test projects #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
commented
Aug 12, 2021
TimothyMothra
commented
Aug 12, 2021
| <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles> | ||
|
|
||
| <!-- Side effect of adding the Test.props, some analyzers are now running in this project. I'll fix these in a follow up PR. --> | ||
| <NoWarn>CS0618</NoWarn> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
FYI: these extra settings were preventing VS and some CLI from running these tests.
rajkumar-rangaraj
approved these changes
Aug 12, 2021
cijothomas
reviewed
Aug 12, 2021
| - net5.0 (EoL Feb 2022) | ||
| - net6.0 (GA Nov 2021) | ||
| --> | ||
| <TargetFrameworks>net462;net472;net480;netcoreapp3.1;net5.0</TargetFrameworks> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of #2251, I'm reviewing all test projects and trying to get them on the same target frameworks.
This PR is pulling some of my changes out of #2361.
I'm cleaning up test projects by removing unused properties:
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />was a bug fix for VS2017 and no longer necessary. (link)Some of the extra properties in the AspNetCore projects were preventing VS and some CLI from running those tests (FIXED!!)
Preparing to move the
<TargetFrameworks>to the Test.props file. We few exceptions, we should have uniformTargetFrameworksacross all our projects.I'll convert individual test projects to use the centralized TargetFrameworks in follow up PRs because this is requiring some other changes in those individual projects (preprocessors and conditional PackageReferences)