Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test projects end up with this GUID #472

Closed
davidfowl opened this issue Feb 12, 2017 · 53 comments
Closed

Test projects end up with this GUID #472

davidfowl opened this issue Feb 12, 2017 · 53 comments
Assignees
Labels

Comments

@davidfowl
Copy link

Is there any way to get rid of this GUID? Can it come from somewhere else? The SDK? Maybe? A nuget package? Why does this exist? Who it for? Can it be inferred?

<ItemGroup>
    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
  </ItemGroup>
@smadala
Copy link
Contributor

smadala commented Feb 12, 2017

VS generates this automatically, to identify project as test project. More details here.

@davidfowl
Copy link
Author

Can we make test projects have their own msbuild sdk to avoid this being added to all test projects?

@codito
Copy link
Contributor

codito commented Feb 13, 2017

#440 is adding a capability for test projects. This guid dependency should go away once VS Test Window starts consuming this.

@davidfowl
Copy link
Author

Is that an RTM feature? I'd love to keep the project files as clean as possible...

@codito
Copy link
Contributor

codito commented Feb 13, 2017

Not planned for RTM currently.

Tagging @sbaid @pvlakshm @srivatsn for bar check.

@codito
Copy link
Contributor

codito commented Feb 14, 2017

Triage: this will require a fix in test window, we should take this in 15.1.

@davidfowl
Copy link
Author

My project file thanks you.

@jnm2
Copy link

jnm2 commented Mar 10, 2017

This kind of noise going back and forth in your source control is a bit irritating, when a bunch of project files suddenly have pending changes and nothing of real consequence happened. I'm really looking forward to getting it out of there.

@NickCraver
Copy link
Member

NickCraver commented Apr 10, 2017

I'm on 15.1 and this is still annoying the crap out of me on every commit trying to sneak its way into my git repo. What's the status of removing this thing?

@JamesNK
Copy link
Member

JamesNK commented Apr 10, 2017

Conscientious csproj citizens don't dirty pristine projects with their grubby GUIDs.

@navin22 navin22 self-assigned this May 10, 2017
@navin22
Copy link
Member

navin22 commented May 10, 2017

This issue is fixed. Fix will be available in the next VS update.

@navin22 navin22 closed this as completed May 10, 2017
@PureKrome
Copy link

Thank you heaps!

@jnm2
Copy link

jnm2 commented May 10, 2017

This issue is fixed. Fix will be available in the next VS update.

Wow so that was quick! Is this the version you're referring to or is it the next one?
https://www.visualstudio.com/en-us/news/releasenotes/vs2017-relnotes#a-id1522643004arelease-date-may-10-2017---version-152-2643004

@codito
Copy link
Contributor

codito commented May 11, 2017

This fix should be part of the next 15.3 preview updates.

@sharwell
Copy link
Member

sharwell commented Jul 30, 2017

@navin22 @codito I just hit this in 3 projects with Visual Studio 2017 version 15.3 Preview 6.

@navin22
Copy link
Member

navin22 commented Jul 31, 2017

@sharwell Does the project have the "TestContainer" Capability?
<ProjectCapability Include="TestContainer" />

BTW, If the service GUID is already added, the fix made can't remove it. It should be removed manually.

@sharwell
Copy link
Member

sharwell commented Jul 31, 2017

Does the project have the "TestContainer" Capability?

I'm assuming you are referring to the UnitTestContainer capability.

I'm not sure. It is possible the bug is currently only affecting cases where this capability is not included. However, it would still be the same bug for these cases. If separate test-related handling is desired for projects which do not have this capability, it needs to be relocated to either the solution user options (*.suo) or the project user options (*.csproj.user).

BTW, If the service GUID is already added, the fix made can't remove it. It should be removed manually.

Yes, this is my expectation.

@jnm2
Copy link

jnm2 commented Jul 31, 2017

If separate test-related handling is desired for projects which do not have this capability, it needs to be relocated to either the solution user options (.suo) or the project user options (.csproj.user).

Absolutely.

@wilhen01
Copy link

wilhen01 commented Mar 7, 2018

Just updated to 15.6 and suddenly seeing this in all our NUnit .csproj files. Yuk.

@wilhen01
Copy link

wilhen01 commented Mar 7, 2018

@smadala or someone else from MS, can we reopen this issue please?

@jnm2
Copy link

jnm2 commented Mar 7, 2018

To reiterate, in case there's a chance: If the presence of this GUID is somehow useful to VS, would you please redirect it into the .vs cache and keep our projects clean?

@ManishJayaswal ManishJayaswal reopened this Mar 7, 2018
@ManishJayaswal
Copy link

@singhsarab - I don't think this was ever fixed. I have reopened the issue.
@navin22 - let's chat offline to understand why this was resolved as fixed and if was indeed fixed then what change in 15.6 brought it back.
@KevinH-MS - FYI

However the good news is that we have actually fixed this in 15.7 release - this time for sure, I promise :-)

We wanted to make this change early in a release to understand all the fall outs since apparently code lens test indicators had a dependency on it. 15.7 Preview 1 will release shortly and that would have this change. We will close this issue after someone in the community has verified that 15.7 release does fix this.

@HppZ
Copy link

HppZ commented Mar 18, 2018

still happen in 15.6.2

@mookid8000
Copy link

Seems to be an issue in 15.6.4 too .... good times 😐

@jnm2
Copy link

jnm2 commented Apr 4, 2018

@HppZ @mookid8000 Like the team said right above your comments, you should not expect this to work until 15.7.

Has anyone installed 15.7 yet? I'm going to play with Blazor when I get a chance, so if no one else wants to confirm the GUID fix I'll do it.

@davkean
Copy link
Member

davkean commented Apr 5, 2018

This has been fixed in 15.7.

@davkean davkean closed this as completed Apr 5, 2018
@davkean davkean added the fixed label Apr 5, 2018
BigYellowHammer added a commit to BigYellowHammer/fluentmigrator that referenced this issue Oct 1, 2020
JSkimming added a commit to JSkimming/Castle.Core.AsyncInterceptor that referenced this issue Nov 2, 2022
0xced added a commit to 0xced/octokit.graphql.net that referenced this issue Aug 18, 2023
* Update test projects from .NET Core 3.1 (out of support) to .NET 6 (LTS)
* Remove `<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />`  (see microsoft/vstest#472 (comment))
* Remove `<LangVersion>7.2</LangVersion>` on test projects
* Fix `Run_Specifies_Cancellation_Token` which (rightfully) throws when running on .NET 6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests