Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Airlock Import Review" and "unrestricted" workspace templates have hardcoded references to TRE versions (0.9.0 and 0.8.0) #3617

Closed
SvenAelterman opened this issue Jul 14, 2023 · 3 comments · Fixed by #3659
Assignees
Labels
airlock bug Something isn't working bundles Creating and deploying bundles/templates

Comments

@SvenAelterman
Copy link
Collaborator

Describe the bug

In line 12 of the Dockerfile.tmpl for the airlock-import-review workspace bundle, the Azure TRE version is hardcoded to 0.9.0.

See https://github.com/microsoft/AzureTRE/blob/8d31b90b1504132a276385da470b204f567a855a/templates/workspaces/airlock-import-review/Dockerfile.tmpl#L12C15-L12C15

It seems this would be problematic because changes to the base workspace bundle won't make it to the airlock import review workspace. This is especially relevant with PR #3581

@SvenAelterman SvenAelterman added the bug Something isn't working label Jul 14, 2023
@SvenAelterman
Copy link
Collaborator Author

I see another challenge with the particular approach of downloading the base workspace files from GitHub. It means that any bug fixes to the base template won't apply to the airlock import review template until a new tag is created.

Would it not be simpler to copy the base workspace files from the local machine?

@SvenAelterman
Copy link
Collaborator Author

I just realized that the unrestricted template has a hardcoded reference also.

@SvenAelterman SvenAelterman changed the title Airlock Import workspace template references TRE version 0.9.0 "Airlock Import Review" and "unrestricted" workspace templates have hardcoded references to TRE versions (0.9.0 and 0.8.0) Jul 14, 2023
@SvenAelterman SvenAelterman added bundles Creating and deploying bundles/templates airlock labels Aug 2, 2023
@marrobi
Copy link
Member

marrobi commented Aug 8, 2023

For now lets update the references, but should look at copying files into the directories and porter dependencies which have progressed since we first did this work.

#3658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airlock bug Something isn't working bundles Creating and deploying bundles/templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants