Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade airlock review and unrestricted workspaces to base v0.12.0 #3659

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Aug 8, 2023

Resolves #3617

How is this addressed

  • Upgrade base version
  • Amend Porter config to work with new base versions

To test:

  • Register new templates
  • Deploy workspaces

image

@marrobi marrobi changed the title Upgrade aurlock review and unrestricted worksapces to base v0.12.0 Upgrade airlock review and unrestricted worksapces to base v0.12.0 Aug 8, 2023
@marrobi marrobi requested a review from SvenAelterman August 8, 2023 11:21
@marrobi marrobi marked this pull request as ready for review August 8, 2023 11:21
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 5f5b642.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Aug 8, 2023

/test-force-approve

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit af258bd)

(in response to this comment from @marrobi)

@marrobi marrobi changed the title Upgrade airlock review and unrestricted worksapces to base v0.12.0 Upgrade airlock review and unrestricted workspaces to base v0.12.0 Aug 8, 2023
Copy link
Collaborator

@SvenAelterman SvenAelterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be two separate PRs: one for the local debugging fixes and one for the referenced versions?

@marrobi
Copy link
Member Author

marrobi commented Aug 8, 2023

Should this be two separate PRs: one for the local debugging fixes and one for the referenced versions?

Doh, I've pulled the other PR into this branch. I've done it with another PR too. Let me try and revert them, unless fancy giving the #3654 a look!

@SvenAelterman
Copy link
Collaborator

Should this be two separate PRs: one for the local debugging fixes and one for the referenced versions?

Doh, I've pulled the other PR into this branch. I've done it with another PR too. Let me try and revert them, unless fancy giving the #3654 a look!

I will look at #3654 but I would like to test that one - and I've never set up local debugging before, so might need some time.

@marrobi
Copy link
Member Author

marrobi commented Aug 8, 2023

@SvenAelterman I've reverted the other files, good spot.

@marrobi marrobi enabled auto-merge (squash) August 8, 2023 16:42
@marrobi
Copy link
Member Author

marrobi commented Aug 8, 2023

/test-force-approve

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 5f5b642)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit b8c7f0b into microsoft:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants