Changes to fix dependency issues and app insights TF issues #3581
Conversation
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5312884945 (with refid (in response to this comment from @marrobi) |
|
/help |
|
🤖 pr-bot 🤖 Hello! You can use the following commands: (in response to this comment from @marrobi) |
|
/test-destroy-env |
|
Destroying PR test environment (RG: rg-tre6b5f52d7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5313475554) |
1 similar comment
|
Destroying PR test environment (RG: rg-tre6b5f52d7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5313475554) |
|
PR test environment destroy complete (RG: rg-tre6b5f52d7) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5315115980 (with refid (in response to this comment from @marrobi) |
|
/test-destroy-env |
|
Destroying PR test environment (RG: rg-tre6b5f52d7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5320887081) |
3 similar comments
|
Destroying PR test environment (RG: rg-tre6b5f52d7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5320887081) |
|
Destroying PR test environment (RG: rg-tre6b5f52d7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5320887081) |
|
Destroying PR test environment (RG: rg-tre6b5f52d7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5320887081) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5333105180 (with refid (in response to this comment from @marrobi) |
|
@marrobi Customer had workspace creation failure for the Airlock Import Review workspace which is remiscent of the failures when deploying some of their basic workspaces. Will updates to that workspace template need to be made too? Any idea when this PR can be reviewed? |
|
@tamirkamara @sachinkundu any idea when this can be reviewed? Thanks. |
templates/workspaces/base/terraform/azure-monitor/azure-monitor.tf
Outdated
Show resolved
Hide resolved
templates/workspaces/base/terraform/azure-monitor/azure-monitor.tf
Outdated
Show resolved
Hide resolved
I don't agree. In East US, we have seen failures during core TRE deployment with 3 of 4 recent deployments, all due to PE failures. While the solution is easy once you know (re-run, determine what TF fails against due to existing resources that weren't captured in TF state, delete those, re-run again), it's not a great experience. |
My comment is first about mixing things that don't have to be together. However, it's correct that I would not like to make the core fix right now - we have limited resources and core changes are much more delicate and I think we should prioritize. |
…r.tf Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@tamirkamara should I split this into 3 separate PRs? One for the workspaces, one for core and one for the app insights AzAPI? I am on leave next week, but can make time to at least get the private endpoint ones done providing we are ok to get them merged. |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5600340721 (with refid (in response to this comment from @marrobi) |
|
/test-force-approve Success here: https://github.com/microsoft/AzureTRE/actions/runs/5600340721/jobs/10244257007 |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 836b7b1) (in response to this comment from @marrobi) |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 5c9be05) (in response to this comment from @marrobi) |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit ac60cec) (in response to this comment from @marrobi) |
Resolves #3569 #3574 #3433 #3616
What is being addressed
Add network dependencies into base workspace and switch to AzAPI for AMLPLS.
Before fixes - deployed 20 workspaces, 8 failed. After, deployed 20, one failures (clashing storage account name).