Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerating Airlock request files after request submission #2504

Conversation

yuvalyaron
Copy link
Collaborator

@yuvalyaron yuvalyaron commented Aug 24, 2022

Resolves #2267

What is being addressed

Populating the files field in Airlock requests (using the Airlock processor since it cannot be done in the API)

How is this addressed

  • Added file enumeration to StatusChangedQueueTrigger , the function will return a step result with the enumerated files. The enumeration will only happen when the new status is "submitted".
  • Refactored the API to handle a "step result" that does not contain a new status - as in the case of file enumeration, only the request files are being sent.
  • Refactored the method for updating Airlock requests to check the ETag of the request, and retry the update if it's not up to date.
  • Added tests.

@github-actions
Copy link

github-actions bot commented Aug 24, 2022

Unit Test Results

514 tests   512 ✔️  13s ⏱️
    2 suites      2 💤
    2 files        0

Results for commit b9e3264.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron changed the title Enumerating Airlock request files when submitting a new request Enumerating Airlock request files after request submission Aug 24, 2022
…ture/2267-enumerating-airlock-files-when-submitting-a-new-request

� Conflicts:
�	CHANGELOG.md
@yuvalyaron yuvalyaron marked this pull request as ready for review August 29, 2022 07:13
@yuvalyaron yuvalyaron requested review from anatbal and removed request for anatbal August 29, 2022 07:14
Copy link
Collaborator

@guybartal guybartal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2949384321 (with refid 2e87af61)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron enabled auto-merge (squash) August 29, 2022 14:41
@yuvalyaron
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2954267779 (with refid 2e87af61)

(in response to this comment from @yuvalyaron)

@yuvalyaron
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2954582840 (with refid 2e87af61)

(in response to this comment from @yuvalyaron)

@yuvalyaron
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2954949171 (with refid 2e87af61)

(in response to this comment from @yuvalyaron)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airlock - Enumerating all files when submitting a new request
3 participants