Skip sending step result events for Airlock updates that do not include a status change

[yuvalyaron]

Resolves #2540, #2534

What is being addressed

As part of #2504, Airlock requests might be updated without updating their status (for instance, enumerating the request files adds the files to the request without changing its status), however the method that updates the requests is also responsible for sending status changed events, so when there is an update to an Airlock request, a status changed event is triggered, in cases where it was not necessary, such as in file enumeration this resulted in duplicated step results.

How is this addressed

• If there is no status change in update_and_publish_event_airlock_request, we skip the send of status changed event
• Added unit tests to enforce the previous bullet
• Changed the E2E test to stop polling the request status if the current status is final and will not change.

[github-actions]

Unit Test Results

499 tests   497 ✔️  12s ⏱️
    1 suites      2 💤
    1 files        0 ❌

Results for commit a3ab664.

♻️ This comment has been updated with latest results.

[yuvalyaron]

/help

[github-actions]

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @yuvalyaron)

[yuvalyaron]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2994413365 (with refid 63211578)

(in response to this comment from @yuvalyaron)

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2994413365 (with refid 63211578)

(in response to this comment from @yuvalyaron)

[yuvalyaron]

/test-destroy-env

[github-actions]

Destroying PR test environment (RG: rg-tre63211578)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2996135545)

[github-actions]

PR test environment destroy complete (RG: rg-tre63211578)

[yuvalyaron]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2997935124 (with refid 63211578)

(in response to this comment from @yuvalyaron)

[yuvalyaron]

/test-destroy-env

[github-actions]

Destroying PR test environment (RG: rg-tre63211578)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2999449040)

[github-actions]

PR test environment destroy complete (RG: rg-tre63211578)

[yuvalyaron]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2999726926 (with refid 63211578)

(in response to this comment from @yuvalyaron)

[yuvalyaron]

/test-destroy-env

[github-actions]

Destroying PR test environment (RG: rg-tre63211578)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3001187006)

[github-actions]

PR test environment destroy complete (RG: rg-tre63211578)

[yuvalyaron]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3001737037 (with refid 63211578)

(in response to this comment from @yuvalyaron)

[yuvalyaron]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3005766060 (with refid 63211578)

(in response to this comment from @yuvalyaron)

[eladiw]

lgtm. minor suggestion

[yuvalyaron]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3007234250 (with refid 63211578)

(in response to this comment from @yuvalyaron)

[yuvalyaron]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3007328448 (with refid 63211578)

(in response to this comment from @yuvalyaron)