Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include AzureML FQDN as a bundle output #3450

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Include AzureML FQDN as a bundle output #3450

merged 2 commits into from
Apr 20, 2023

Conversation

LizaShak
Copy link
Collaborator

Resolves #3448

What is being addressed

Output the Aml service fqdn as a bundle output. This is needed for the next step where it is added to the firewall rules.

@LizaShak LizaShak requested a review from marrobi April 20, 2023 09:00
@LizaShak
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4752445541 (with refid d4cc8151)

(in response to this comment from @LizaShak)

@github-actions
Copy link

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit a5dc3ee.

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, providing the regex bit works :)

@LizaShak LizaShak merged commit 617d5bf into main Apr 20, 2023
@LizaShak LizaShak deleted the lishakur/fix-aml branch April 20, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AML workspace service fails to install and puts firewall into failed state
2 participants