Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include AzureML FQDN as a bundle output #3450

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Include AzureML FQDN as a bundle output #3450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7909bc
Fix aml outputs
LizaShak Apr 20, 2023
a5dc3ee
Update changelog and version
LizaShak Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ ENHANCEMENTS:
* Update Guacamole to version 1.5.1 ([#3443](https://github.com/microsoft/AzureTRE/issues/3443))

BUG FIXES:
* AML workspace service fails to install and puts firewall into failed state ([#3448](https://github.com/microsoft/AzureTRE/issues/3448))

COMPONENTS:

Expand Down
9 changes: 8 additions & 1 deletion templates/workspace_services/azureml/porter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
schemaVersion: 1.0.0
name: tre-service-azureml
version: 0.8.1
version: 0.8.2
description: "An Azure TRE service for Azure Machine Learning"
registry: azuretre
dockerfile: Dockerfile.tmpl
Expand Down Expand Up @@ -115,6 +115,11 @@ outputs:
applyTo:
- install
- upgrade
- name: aml_fqdn
type: string
applyTo:
- install
- upgrade

mixins:
- terraform:
Expand Down Expand Up @@ -155,6 +160,7 @@ install:
- name: storage_tag
- name: batch_tag
- name: mcr_tag
- name: aml_fqdn

upgrade:
- terraform:
Expand Down Expand Up @@ -188,6 +194,7 @@ upgrade:
- name: storage_tag
- name: batch_tag
- name: mcr_tag
- name: aml_fqdn

uninstall:
- terraform:
Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/azureml/terraform/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ output "azureml_storage_account_id" {
}

output "aml_fqdn" {
value = module.terraform_azurerm_environment_configuration.aml_studio_endpoint
value = regex("(?:(?P<scheme>[^:/?#]+):)?(?://(?P<fqdn>[^/?#:]*))?", module.terraform_azurerm_environment_configuration.aml_studio_endpoint).fqdn
}

output "connection_uri" {
Expand Down