Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable admins to see workspace details and operations without a workspace role #3722

Merged
merged 12 commits into from
Oct 5, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Sep 21, 2023

Fixes #2363

How is this addressed

  • Make resource card clickable for admins even if auth provision has failed,
  • Only display workspace item if TRE Admin but no workspace roles has failed and disable other workspace routes.

image

@marrobi marrobi enabled auto-merge (squash) September 21, 2023 19:31
@marrobi marrobi requested a review from jjgriff93 September 21, 2023 19:32
@marrobi
Copy link
Member Author

marrobi commented Sep 21, 2023

/test-force-approve

UI only

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 1d16c94)

(in response to this comment from @marrobi)

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 5ad3dd0.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as draft September 22, 2023 07:54
auto-merge was automatically disabled September 22, 2023 07:54

Pull request was converted to draft

@marrobi marrobi changed the title UI: AAD Workspace creation failure results in not being able to see the error message. Enable admins to see workspace details and operations without a workspace role Sep 22, 2023
@marrobi marrobi marked this pull request as ready for review September 22, 2023 09:20
@marrobi marrobi enabled auto-merge (squash) September 22, 2023 13:04
@marrobi
Copy link
Member Author

marrobi commented Sep 22, 2023

/test-force-approve

UI only

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 02bb546)

(in response to this comment from @marrobi)

Copy link
Collaborator

@jjgriff93 jjgriff93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor suggestions

marrobi and others added 2 commits September 25, 2023 08:51
@marrobi
Copy link
Member Author

marrobi commented Sep 25, 2023

/test-force-approve

UI only

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit eb2adc4)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Sep 27, 2023

/test-force-approve

UI only

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit be914b9)

(in response to this comment from @marrobi)

Copy link
Collaborator

@jjgriff93 jjgriff93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@marrobi
Copy link
Member Author

marrobi commented Oct 5, 2023

/test-force-approve

UI only

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 5ad3dd0)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit e396652 into microsoft:main Oct 5, 2023
10 checks passed
@marrobi marrobi deleted the marrobi/issue2363 branch October 5, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: AAD Workspace creation failure results in not being able to see the error message.
2 participants