subtitle in form editor #1662
Merged
subtitle in form editor #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanlong9278
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
boydc2014
pushed a commit
that referenced
this pull request
Nov 29, 2019
* new trigger * add `subtitle` in ConceptLabels to override some title * refine new css of Trigger * fix an unsafe prop visit * fix eslint import path * move styles to 'triggerStyles.ts' * use lodash.get in Trigger.tsx * add subtitle in form editor (#1662) * Final changes * Remove unnecessary guard * enable debug when running tests * fix ci: BreadCrumb * fix ci: CreateNewBot * revert BreadCrumb * delete data.json before each e2e test * More labeling * Fix e2e test * fix visual designer spec * use findAllBy for breadcrumb spec sometimes more than one breadcrumb is found. this will use the last one found * use debug logger * pipe server output to log file and print after tests are run * fix up e2e script * run headless * pipe server logs to file * only invoke cleanup function once * fix visual designer spec again * display server logs * add more debug logging * always print e2e logs * Base leileizh's e2e fixes * update the node env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
subtitle in form editor
If this is a bug fix, please describe the root cause and analysis of this problem.
Task Item
Please include a link to the related issue. Ex.
Closes #<issue #>Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.