a11y: reapply tooltip additions #3362
Conversation
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
| @@ -8,7 +8,7 @@ context('LU Page', () => { | |||
| }); | |||
|
|
|||
| it('can open language understanding page', () => { | |||
| cy.findByTestId('LeftNav-CommandBarButtonUser Input').click(); | |||
| cy.findByTestId('LeftNav-CommandBarButtonUser Input').click({ force: true }); | |||
There was a problem hiding this comment.
Let's make this work without using force.
There was a problem hiding this comment.
I'm not sure we can. Without force, the e2e tests were failing because, while Cypress could see the element it wanted to click, it complained that the element was being covered by something, and some investigation showed that that something else was the tooltip's active region. I could see if making Cypress click on the tooltip region works, but that doesn't seem like a natural way to test the behavior we actually want.
There was a problem hiding this comment.
On further inspection, the e2e tests are still failing even with force, so I'll figure out another way to do this.
There was a problem hiding this comment.
Thanks for looking at this.
There was a problem hiding this comment.
It looks like those failures were transient. They were definitely failing without force, though, so I think we still might need it.
There was a problem hiding this comment.
We should figure out why we need it. To me, this lowers my confidence in these tests because it could lead to false positives.
| @@ -59,7 +59,7 @@ context('Notification Page', () => { | |||
| cy.findByTestId('FieldErrorMessage').should('exist'); | |||
| }); | |||
|
|
|||
| cy.findByTestId('LeftNav-CommandBarButtonNotifications').click(); | |||
| cy.findByTestId('LeftNav-CommandBarButtonNotifications').click({ force: true }); | |||
| @@ -41,7 +41,7 @@ context('Notification Page', () => { | |||
| cy.findAllByText('__TestToDoBotWithLuisSample').should('exist'); | |||
| }); | |||
|
|
|||
| it('can show dialog expression error ', () => { | |||
| it.only('can show dialog expression error ', () => { | |||
There was a problem hiding this comment.
Oops. Yeah, I'll fix that.
* reapply tooltip additions * maybe fix e2e tests * merge and resolve conflicts * Update OpenObjectField.tsx * remove force:true * fix logic on nav tooltips * Update LUPage.spec.ts * re-remove plugins directory (moved in another commit) * add parentsUntil to tests * fix tests * fix tests * defocus tooltips during tests
Description
This is a reapplication of the changes from @corinagum 's work on #2691, after that old PR and the master branch diverged enough that trying to rebase just leading to a larger and larger mess over time.
Task Item
refs #2006
Screenshots
See screenshots in #2691