a11y: Add tooltip to icon buttons #2691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten and
yeze322
as code owners
* fix link accessibility issue in about page * resolve conflict Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
* a11y: add home page elements to tab index * Update home.test.js * Update home.test.js Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
* re-enable publish page in settings * add description to publish plugin, fix behavior of "Default" local test target * add publish page in nav * add publish page * remove unrelevant * add publish page and add getHistory method in localpublish plugin * fix bug * polish style * add mock remote publish for development/testing purposes * add alerts on failed validation * add validation chck * update typedefs flatten and standardize result payload * poll for updated stats if status is 202 * fix build fail * add sensitive setting back and polish UI * fix localpublish * add testInEmulator button * add group in detail list * add log output * bind the log button to the actual log content from the publish process * add supported features to return value of types api * add default into profile * remove default show in profile list * add rollback methods * add rollback endpoint, mock rollback feature, rollback button in ui * fix build * change status show in list to icon * polish * fix e2e test * disable open in emulator button, clean consoles * change date format * add targetName into url * add delete in target list, add edit placehold in target list * fix save target * fix selectVersion after changing target * implement confirm on delete of target implement edit of target * add error correction implement edit/delete * fix name undefined when adding target: * fix some comments * fix comment * redirect to new target after create and edit, and fix date sort * fix comments * fix history update after publish fail * resolve comments from cwhitten * fix some code issues Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
|
this is nice :) |
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* WIP: export ui * Add export to zip functionality * Refactor export * Add skill-settings.tsx * Serialize to settings * Cleanup * Adds comment * Supports platform path separator in Export * Get rid of .Main * PR feedback
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
* add circle outline for add button * add set menuSelected false callback Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
beyackle
suggested changes
Apr 17, 2020
* can access the cell of detailsList * remove unused import Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
…ckage (microsoft#2704) * feat: Added required indicator to field labels in the AdaptiveForm package * Removed schema change
|
Didn't get to this in time today. I'll do my best to get to it next week. |
…t#2681) * init * improvement * change suggestion item kind * add fixedOverflowWidgets to base editor options Co-authored-by: Andy Brown <asbrown002@gmail.com>
* change - in template name to _ for all sample bots
* update lg naming pattern
* update tests
* add method to convert template name when loading
* Inline LU naming conventions in the prompts
# TextInput.response-RuZhXe -> ${inputType}_Response_${id}
* update lg name pattern
* replace bfdactivity -> SendActivity
* activity -> SendActivity
* bfdprompt_1234 -> TextInput_Prompt_1234
* designerId no dash -
* lgField use schema.$kind as lgNameType
* use standalone method generate designer id
* Update packages
* Update sdk.schema
* more replacement
* change LG package version
* upgrade lg package
* fix api of Expression
* Update BotProject.csproj
update to the latest which include:
1. skill support
2. foreach and foreachPage nested fix.
* update sample bot
* use SDKKinds
* use shared lu name builder
* Update LanguagePolicy and IRecognzier
* Recognizer -> IRecognizer
* Update to the latest 200416
which include repeat option fix and OAuth ifx
* Fix for skill AutoEndDialog
* upgrade luis package
* replace cover ${ } and @{ } expression syntax
* upgrade luis package fix dash -
* handle file write error
* use a placeholder luSectionName
Co-authored-by: Shuai Wang <shuwan@microsoft.com>
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* rename e2e script to e2e-ci * [wip] start cross env e2e script * add assertion on visit page method * add @bfc/test-utils package * update visual designer to use test-utils * mark test-utils private * update adaptive-form to use test-utils * migrate extension to test-utils * migrate client to test-utils * update config function interfaces * add node configuration * update lockfile * migrate electron-server to test-utils * migrate lib to test-utils * migrate server to test-utils * migrate tools to test-utils * migrate ui-plugins to test-utils * update lock file * update documentation * add typings for test-utils Keep this as a JS module to reduce compile steps, but at least consumers get type info * convert all test imports to test-utils * allow configuration of babel options * convert missing js files to jsx * remove ability for babel overrides packages can include their own babel config instead * remove babel overrides from type * migrate ui-shared to test-utils * do not load other babel configs for tests * add e2e scripts to run app and clean artifacts in cross plat way * add more logging * add yarn script to start composer for e2e
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* show botendpoint as tooltip * fix lint * Fix tests * add a button to write to clipboard * fix lint * remove close delay and URL prefix Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: support the cross train corner case * update the unit test * update the config * add config for all other kinds triggers Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
|
I'm going to take this up again and see if I can smooth out all the conflicts. |
|
The work here has been reapplied to master in #3362. Closing this one in favor of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tooltip to IconButtons
Task Item
Fixes #2006
Screenshots