test: increase 'adaptive-flow' test coverage to 77% #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
changed the title
yeze322
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
yeze322
changed the title
cwhitten
approved these changes
Jul 1, 2020
srinaath
added a commit
that referenced
this pull request
Jul 1, 2020
* test: increase 'adaptive-flow' test coverage to 77% (#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
VanyLaw
added a commit
that referenced
this pull request
Jul 3, 2020
…3453) * Remove language specific features from core and into runtime plugin * cleanup a bit of the azurepublish plugin for readability * move some code, add some comments * refactor bot project deploy and split into several sub-classes. move this from inside composer into the plugin * remove bot-deploy package combine azurePublish and azureFunctionsPublish refine buildDeploy api method to allow for knowledge of what target is being built for * remove azureFunctionsPublish (replaced by azureFunctions) * fix to node runtime * allow start bot button to be async * clean up dependencies, paths * remove rimraf yarn.lock in package.json and catch error during setBot * merge settings and write once inside the runtime plugin * make sure to use exec instead of execSync * make sure everything happens in the right order don't use console.log * identify runtime by name field * update luis package in azurePublish plugin and fix getRuntimeByProject * remove lib folder in azurePublish * test: increase 'adaptive-flow' test coverage to 77% (#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: adds webpack bundle analyzer (#3542) * issues#3309 * fixes lints * Default to bot settings if no route cache * fix: #3485 * fix: #3486 Debug/Fix HMR support * webpack bundle analyzer Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: split some actions off setSettings (#3525) * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * Update setting.ts * fix some tests * Update index.ts * move logo-clicking to commands.ts * Update commands.ts * fix: Dialog validate throw error when delete an action (#3537) * fix: Dialog validate throw error when delete an action * use optional chaining and more explicit length check * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * use const instead of raw http status values * rename js runtime to node-azurewebapp Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: leileizhang <leilzh@microsoft.com>
GeoffCoxMSFT
added a commit
that referenced
this pull request
Jul 6, 2020
* fix: add logo-clicking to tests (#3500) * add logo-clicking to tests * bump elliptic version * Update yarn.lock Co-authored-by: Andy Brown <asbrown002@gmail.com> * feat: support validate lg custom functions (#3273) * fix: support validate lg custom functions and separate the dialog validation from parser * use file name as namespace * add unit test * fix lint * fix: inline editing LU mess up whole file (#3478) * upgrade lu packages * update package * clean * update * clean up Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: change term primary key to authoring key (#3516) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: replace the endpoint to authoringEndpoint when publishing luis (#3517) Co-authored-by: Andy Brown <asbrown002@gmail.com> * propagate code editor settings to all editor surfaces (#3520) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * run coverage on all source files (#3522) without this config, jest would only collect coverage on files that were imported in a test * feat: add loading indicator when waiting on form data or schema to load (#3523) * move AdaptiveForm components out of sub directory * show loading spinner while waiting for form data and schema Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * feat: allow inputting path (#3302) * allow input path * handle corner case * lint fix * fix the flicker issue * update UX and create or update folder operation * refine code structure * remove commented code * fix unit test * use esc to cancel operation * handle comments * handle comments * add test case * fix test case Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: Index file renames part 1 (#3519) * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Renamed components, hooks, Onboarding only * Renamed components, hooks, Onboarding only * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Fixing imports * test: increase 'adaptive-flow' test coverage to 77% (#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: adds webpack bundle analyzer (#3542) * issues#3309 * fixes lints * Default to bot settings if no route cache * fix: #3485 * fix: #3486 Debug/Fix HMR support * webpack bundle analyzer Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: split some actions off setSettings (#3525) * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * Update setting.ts * fix some tests * Update index.ts * move logo-clicking to commands.ts * Update commands.ts * fix: Dialog validate throw error when delete an action (#3537) * fix: Dialog validate throw error when delete an action * use optional chaining and more explicit length check * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: composer will crashed when add a new publish profile (#3550) * replace function callbacks with arrows (#3545) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: location initialization (#3549) * fix bug * fix e2e test * fix bug * chore: Index file renames part 2 (#3546) * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Renamed components, hooks, Onboarding only * Renamed components, hooks, Onboarding only * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Fixing imports * Index file renames Part 2 Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com>
Merged
GeoffCoxMSFT
added a commit
that referenced
this pull request
Jul 10, 2020
* fix: add logo-clicking to tests (#3500) * add logo-clicking to tests * bump elliptic version * Update yarn.lock Co-authored-by: Andy Brown <asbrown002@gmail.com> * feat: support validate lg custom functions (#3273) * fix: support validate lg custom functions and separate the dialog validation from parser * use file name as namespace * add unit test * fix lint * fix: inline editing LU mess up whole file (#3478) * upgrade lu packages * update package * clean * update * clean up Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: change term primary key to authoring key (#3516) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: replace the endpoint to authoringEndpoint when publishing luis (#3517) Co-authored-by: Andy Brown <asbrown002@gmail.com> * propagate code editor settings to all editor surfaces (#3520) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * run coverage on all source files (#3522) without this config, jest would only collect coverage on files that were imported in a test * feat: add loading indicator when waiting on form data or schema to load (#3523) * move AdaptiveForm components out of sub directory * show loading spinner while waiting for form data and schema Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * feat: allow inputting path (#3302) * allow input path * handle corner case * lint fix * fix the flicker issue * update UX and create or update folder operation * refine code structure * remove commented code * fix unit test * use esc to cancel operation * handle comments * handle comments * add test case * fix test case Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: Index file renames part 1 (#3519) * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Renamed components, hooks, Onboarding only * Renamed components, hooks, Onboarding only * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Fixing imports * test: increase 'adaptive-flow' test coverage to 77% (#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: adds webpack bundle analyzer (#3542) * issues#3309 * fixes lints * Default to bot settings if no route cache * fix: #3485 * fix: #3486 Debug/Fix HMR support * webpack bundle analyzer Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: split some actions off setSettings (#3525) * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * Update setting.ts * fix some tests * Update index.ts * move logo-clicking to commands.ts * Update commands.ts * fix: Dialog validate throw error when delete an action (#3537) * fix: Dialog validate throw error when delete an action * use optional chaining and more explicit length check * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: composer will crashed when add a new publish profile (#3550) * replace function callbacks with arrows (#3545) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: location initialization (#3549) * fix bug * fix e2e test * fix bug * chore: Index file renames part 2 (#3546) * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Renamed components, hooks, Onboarding only * Renamed components, hooks, Onboarding only * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Fixing imports * Index file renames Part 2 * fix: deploy issue while zipping the folder (#3557) * move bot-deploy to plugins * fix profile edit and save not saving to settings * add dependency to electron-server * update settings file clicking customized runtime toggle Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> * docs: archive old docs (#3572) Co-authored-by: Andy Brown <asbrown002@gmail.com> * chore(deps-dev): bump electron from 8.0.2 to 8.2.4 in /Composer (#3577) Bumps [electron](https://github.com/electron/electron) from 8.0.2 to 8.2.4. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md) - [Commits](electron/electron@v8.0.2...v8.2.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tony Anziano <toanzian@microsoft.com> * Bumped electron-builder config to correct electron version. (#3584) * doc: add some missing details to plugin readme (#3585) * handle schema parsing error better (#3586) * fix nodemon `--inspect` error in lgWorker (#3590) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * feat: Disable / Enable actions (#3416) * impl disable/enable editor API * disable / enable e2e * propagate the 'disabled' property * take css out of CardTemplate * take css out of ActionHeader * connect to the 'disabled' property in data * CSS: disbaled effect * update icon of Disabled/Enabled * rename inheritParentProperty * shallow copy json in IndexedNode to support immutable * rename files with '.style' suffix * apply disable effect to PromptWidget * only disable nodes when disabled === true * contextual Disable/Enable btn state * move disable/enable button into toolbar * avoid undefined array in UT * release: 1.0.2 (#3595) * Change versions * Adds 1.0.2.md * update uncategorized commits Co-authored-by: Andy Brown <asbrown002@gmail.com> * chore: Moved styles inline for components in client package. (#3598) * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Renamed components, hooks, Onboarding only * Renamed components, hooks, Onboarding only * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Fixing imports * Index file renames Part 2 * Inlined styles in ts * Fixed test mocks * feat: grouping Toolbar buttons under the 'Edit' dropdown button (#3608) * let ToolBar support 'dropdown' type * move 'design' page only toolbar items into DesignPage * migrate 'Add New Trigger' coachmark feature * grouping 'Edit' buttons together as a dropdown * loosen 'type' TS type in toolbar * fix: Syntax error when creating a "Send a response" node (#3604) * refine diagnostics * fix lg parse line number range * update inline diagnostic * update test * resue websocket connection Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Merge from master with fixes Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Yan Liu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tony Anziano <toanzian@microsoft.com> Co-authored-by: Ben Brown <benbro@microsoft.com>
cwhitten
added a commit
that referenced
this pull request
Aug 19, 2020
* add js runtime * set copy button disable when copying * updated js runtime to load settings correctly * updated js runtime to load settings correctly * add js runtime publish * add runtime config * fixed sample templates * read folder path from settings * change publish folder for js runtime * exlucde *.zip from archived files * fixed appsettings path for deployment * added web.config as well as iisnode.yml configuration files for deployment * compiled js runtime * merge settings * enum value to lower case * fixed zip deployment issue * deploy js runtime without eject * js runtime lib files * fix restart * fix lint * fix zip runtime * fix bot-deploy package can not update in azurepublish plugin * fix copy runtime everytime when local publish * updated configuration files for deployment * add yarn install in first time clicking start * bump runtime dependencies' version * fix deploy absolute url and include .deployment into zip * decouple platform in localpublish plugin * move some code into nodejs runtime core * merge master * fix profile edit and save not saving to settings * Remove language specific features from core and into runtime plugin (#3453) * Remove language specific features from core and into runtime plugin * cleanup a bit of the azurepublish plugin for readability * move some code, add some comments * refactor bot project deploy and split into several sub-classes. move this from inside composer into the plugin * remove bot-deploy package combine azurePublish and azureFunctionsPublish refine buildDeploy api method to allow for knowledge of what target is being built for * remove azureFunctionsPublish (replaced by azureFunctions) * fix to node runtime * allow start bot button to be async * clean up dependencies, paths * remove rimraf yarn.lock in package.json and catch error during setBot * merge settings and write once inside the runtime plugin * make sure to use exec instead of execSync * make sure everything happens in the right order don't use console.log * identify runtime by name field * update luis package in azurePublish plugin and fix getRuntimeByProject * remove lib folder in azurePublish * test: increase 'adaptive-flow' test coverage to 77% (#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: adds webpack bundle analyzer (#3542) * issues#3309 * fixes lints * Default to bot settings if no route cache * fix: #3485 * fix: #3486 Debug/Fix HMR support * webpack bundle analyzer Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: split some actions off setSettings (#3525) * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * Update setting.ts * fix some tests * Update index.ts * move logo-clicking to commands.ts * Update commands.ts * fix: Dialog validate throw error when delete an action (#3537) * fix: Dialog validate throw error when delete an action * use optional chaining and more explicit length check * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * use const instead of raw http status values * rename js runtime to node-azurewebapp Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: leileizhang <leilzh@microsoft.com> * fix js runtime in core * fix js runtime local publish * fix exclude paths not working in copyDir * delete bot-deploy in lib * merge nodejs runtime packages into one and fix deploy path error * fix yarn to install lu 4.10.0 * fix merge conflict * enable switch runtime in managed mode * add npmrc to set registry in azure, make sure daily build version package can be install * fix several comments * fix comments * fix luisbot deploy endpointKey issue and send 202 response before runtime template copy * fix luisbot deploy endpointKey issue and send 202 response before runtime template copy * fix ut in eject * move DialogSetting interface into shared folder * fix build error * fix e2e test fail * add test for js runtime * dotnet runtime luis settings refactor, remove duplicate settings file (#3677) * remove appsettings.deployment.json and appsettings.development.json * fix get publish status after merge main * some updates to the plugins README to include new functionality * additional docs for the plugin APIs * upgrade dependency * support skills * optimized structure of js runtime * to get correct project root * added manifest support in js runtime * ignored lib folder in js runtime * updated docs of js runtime * fix some comments * removed skills validation * remove appsettings.json in dotnet * fixed case issue of microsoft app id * increased param length limit of web server * shared skill conversation id factory * remove listener before stop bot, move manifest saving into runtime plugin * fix unit test * modify node runtime actions test, add node runtime test into CI * modify all node runtime tests * add working directory in ci yml * add preview in js eject and update restify package version * add ts into dev dep * build after eject * added test cases for skill conversation id factory * fix npm build involve jest in production environment * polish * fix some comments * add eslint and fix lint * updated set output target of typescript to es6 * use lodash merge instead object assign * change method parameter to object, move botStatusInterval from recoil to component * remove templatePath in publish api call and get it in plugins by runtime type in project * azure functions in js runtime * polish exec in runtime plugin, use lodash mergeWith to replace original mergeDeep * polish runtime plugin * make console log in azure publish plugin to logger * fix mkdir error in runtime plugin; popup confirm dialog instead error when customized runtime existed * stop bot before switch eject runtime * ignore warning and error in npm install, modify schema folder into Schema folder in eject, in case linux eject * add doc for js runtime * polish * polish * modify readme * merge multi parameter into object Co-authored-by: Zichuan Ma <zim@microsoft.com> Co-authored-by: Qi Kang <qika@microsoft.com> Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
benbrown
added a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
…icrosoft#3453) * Remove language specific features from core and into runtime plugin * cleanup a bit of the azurepublish plugin for readability * move some code, add some comments * refactor bot project deploy and split into several sub-classes. move this from inside composer into the plugin * remove bot-deploy package combine azurePublish and azureFunctionsPublish refine buildDeploy api method to allow for knowledge of what target is being built for * remove azureFunctionsPublish (replaced by azureFunctions) * fix to node runtime * allow start bot button to be async * clean up dependencies, paths * remove rimraf yarn.lock in package.json and catch error during setBot * merge settings and write once inside the runtime plugin * make sure to use exec instead of execSync * make sure everything happens in the right order don't use console.log * identify runtime by name field * update luis package in azurePublish plugin and fix getRuntimeByProject * remove lib folder in azurePublish * test: increase 'adaptive-flow' test coverage to 77% (microsoft#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (microsoft#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (microsoft#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: adds webpack bundle analyzer (microsoft#3542) * issues#3309 * fixes lints * Default to bot settings if no route cache * fix: microsoft#3485 * fix: microsoft#3486 Debug/Fix HMR support * webpack bundle analyzer Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: split some actions off setSettings (microsoft#3525) * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * Update setting.ts * fix some tests * Update index.ts * move logo-clicking to commands.ts * Update commands.ts * fix: Dialog validate throw error when delete an action (microsoft#3537) * fix: Dialog validate throw error when delete an action * use optional chaining and more explicit length check * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * use const instead of raw http status values * rename js runtime to node-azurewebapp Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: leileizhang <leilzh@microsoft.com>
benbrown
added a commit
that referenced
this pull request
Jun 11, 2021
…3453) * Remove language specific features from core and into runtime plugin * cleanup a bit of the azurepublish plugin for readability * move some code, add some comments * refactor bot project deploy and split into several sub-classes. move this from inside composer into the plugin * remove bot-deploy package combine azurePublish and azureFunctionsPublish refine buildDeploy api method to allow for knowledge of what target is being built for * remove azureFunctionsPublish (replaced by azureFunctions) * fix to node runtime * allow start bot button to be async * clean up dependencies, paths * remove rimraf yarn.lock in package.json and catch error during setBot * merge settings and write once inside the runtime plugin * make sure to use exec instead of execSync * make sure everything happens in the right order don't use console.log * identify runtime by name field * update luis package in azurePublish plugin and fix getRuntimeByProject * remove lib folder in azurePublish * test: increase 'adaptive-flow' test coverage to 77% (#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: adds webpack bundle analyzer (#3542) * issues#3309 * fixes lints * Default to bot settings if no route cache * fix: #3485 * fix: #3486 Debug/Fix HMR support * webpack bundle analyzer Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: split some actions off setSettings (#3525) * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * Update setting.ts * fix some tests * Update index.ts * move logo-clicking to commands.ts * Update commands.ts * fix: Dialog validate throw error when delete an action (#3537) * fix: Dialog validate throw error when delete an action * use optional chaining and more explicit length check * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * use const instead of raw http status values * rename js runtime to node-azurewebapp Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: leileizhang <leilzh@microsoft.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* test: increase 'adaptive-flow' test coverage to 77% (microsoft#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (microsoft#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (microsoft#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add js runtime * set copy button disable when copying * updated js runtime to load settings correctly * updated js runtime to load settings correctly * add js runtime publish * add runtime config * fixed sample templates * read folder path from settings * change publish folder for js runtime * exlucde *.zip from archived files * fixed appsettings path for deployment * added web.config as well as iisnode.yml configuration files for deployment * compiled js runtime * merge settings * enum value to lower case * fixed zip deployment issue * deploy js runtime without eject * js runtime lib files * fix restart * fix lint * fix zip runtime * fix bot-deploy package can not update in azurepublish plugin * fix copy runtime everytime when local publish * updated configuration files for deployment * add yarn install in first time clicking start * bump runtime dependencies' version * fix deploy absolute url and include .deployment into zip * decouple platform in localpublish plugin * move some code into nodejs runtime core * merge master * fix profile edit and save not saving to settings * Remove language specific features from core and into runtime plugin (microsoft#3453) * Remove language specific features from core and into runtime plugin * cleanup a bit of the azurepublish plugin for readability * move some code, add some comments * refactor bot project deploy and split into several sub-classes. move this from inside composer into the plugin * remove bot-deploy package combine azurePublish and azureFunctionsPublish refine buildDeploy api method to allow for knowledge of what target is being built for * remove azureFunctionsPublish (replaced by azureFunctions) * fix to node runtime * allow start bot button to be async * clean up dependencies, paths * remove rimraf yarn.lock in package.json and catch error during setBot * merge settings and write once inside the runtime plugin * make sure to use exec instead of execSync * make sure everything happens in the right order don't use console.log * identify runtime by name field * update luis package in azurePublish plugin and fix getRuntimeByProject * remove lib folder in azurePublish * test: increase 'adaptive-flow' test coverage to 77% (microsoft#3530) * + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker * update a test case (microsoft#3531) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix lgWorker test failure (microsoft#3529) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * chore: adds webpack bundle analyzer (microsoft#3542) * issues#3309 * fixes lints * Default to bot settings if no route cache * fix: microsoft#3485 * fix: microsoft#3486 Debug/Fix HMR support * webpack bundle analyzer Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * refactor: split some actions off setSettings (microsoft#3525) * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * Update setting.ts * fix some tests * Update index.ts * move logo-clicking to commands.ts * Update commands.ts * fix: Dialog validate throw error when delete an action (microsoft#3537) * fix: Dialog validate throw error when delete an action * use optional chaining and more explicit length check * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * use const instead of raw http status values * rename js runtime to node-azurewebapp Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: leileizhang <leilzh@microsoft.com> * fix js runtime in core * fix js runtime local publish * fix exclude paths not working in copyDir * delete bot-deploy in lib * merge nodejs runtime packages into one and fix deploy path error * fix yarn to install lu 4.10.0 * fix merge conflict * enable switch runtime in managed mode * add npmrc to set registry in azure, make sure daily build version package can be install * fix several comments * fix comments * fix luisbot deploy endpointKey issue and send 202 response before runtime template copy * fix luisbot deploy endpointKey issue and send 202 response before runtime template copy * fix ut in eject * move DialogSetting interface into shared folder * fix build error * fix e2e test fail * add test for js runtime * dotnet runtime luis settings refactor, remove duplicate settings file (microsoft#3677) * remove appsettings.deployment.json and appsettings.development.json * fix get publish status after merge main * some updates to the plugins README to include new functionality * additional docs for the plugin APIs * upgrade dependency * support skills * optimized structure of js runtime * to get correct project root * added manifest support in js runtime * ignored lib folder in js runtime * updated docs of js runtime * fix some comments * removed skills validation * remove appsettings.json in dotnet * fixed case issue of microsoft app id * increased param length limit of web server * shared skill conversation id factory * remove listener before stop bot, move manifest saving into runtime plugin * fix unit test * modify node runtime actions test, add node runtime test into CI * modify all node runtime tests * add working directory in ci yml * add preview in js eject and update restify package version * add ts into dev dep * build after eject * added test cases for skill conversation id factory * fix npm build involve jest in production environment * polish * fix some comments * add eslint and fix lint * updated set output target of typescript to es6 * use lodash merge instead object assign * change method parameter to object, move botStatusInterval from recoil to component * remove templatePath in publish api call and get it in plugins by runtime type in project * azure functions in js runtime * polish exec in runtime plugin, use lodash mergeWith to replace original mergeDeep * polish runtime plugin * make console log in azure publish plugin to logger * fix mkdir error in runtime plugin; popup confirm dialog instead error when customized runtime existed * stop bot before switch eject runtime * ignore warning and error in npm install, modify schema folder into Schema folder in eject, in case linux eject * add doc for js runtime * polish * polish * modify readme * merge multi parameter into object Co-authored-by: Zichuan Ma <zim@microsoft.com> Co-authored-by: Qi Kang <qika@microsoft.com> Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refs #3456
closes #3530
Add more unit tests to 'adaptive-flow'. Test coverage increases from 40% to 77%.
Low coverage modules (under 70% baseline) & reasons:
adaptive-flow-editor/utils/cursorTracker- 41.78% - @alanlong9278 to improve it lateradaptive-flow-renderer/configs/builtinSchema- 3% (pure json, not testable)adaptive-flow-editor/AdaptiveFlowEditor- 65.91% - event handlers not covered by UT but by E2E testTask Item
Screenshots