Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump electron from 8.0.2 to 8.2.4 in /Composer #3577

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 7, 2020

Bumps electron from 8.0.2 to 8.2.4.

#minor

Release notes

Sourced from electron's releases.

electron v8.2.4

Release Notes for v8.2.4

Fixes

  • Fixed Promise timeout issue when running Electron as Node. #23234
  • Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu. #23181
  • Fixed an issue where windows without nativeWindowOpen: true could invoke the non-native-open path. #23225
  • Fixed broken use of contextCodeGeneration parameter to Node.js' script.runInNewContext(). #23147
  • Fixed memory leak when using contextBridge with sandbox=true. #23231

Other Changes

  • Updated Chromium to 80.0.3987.165. #23217

electron v8.2.3

Release Notes for v8.2.3

Fixes

  • Security: Ensure proxy object is created in the correct context b8e34770

electron v8.2.2

Release Notes for v8.2.2

Fixes

  • Fixed a crash that could happen when attempting to access a session during shutdown. #23069
  • Fixed an issue with maximizable state persistence of BrowserWindows on macOS. #23020
  • Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS. #23088
  • Fixed an occasional crash when closing all BrowserWindows. #23022
  • Fixed occasional WebFrame crashes caused by removed iframes. #22975

Other Changes

electron v8.2.1

Release Notes for v8.2.1

Fixes

  • Accessing the screen module before the ready event no longer makes it impossible to access the screen module. #22913
  • Added workaround for nativeWindowOpen hang. #22749
  • Enable offscreen rendering. #22431
  • Fixed an issue where native macOS dialogs sometimes failed to show after modal close. #22889
  • Fixed issue where prefers-color-scheme would not be updated / set correctly when your OS was in dark mode. #22901

Other Changes

Commits
  • d8f9044 Bump v8.2.4
  • 0453316 refactor: port window-setup to use ctx bridge instead of being run in the mai...
  • 0ac4212 style: use build/include_directory for NOLINT (#23266) (#23303)
  • ce04014 fix: use Node's microtasks policy in node_main.cc (#23234)
  • 19bd97d ci: robustify doc only change check (#23258)
  • ea2e34c chore: bump chromium to 80.0.3987.165 (8-x-y) (#23217)
  • 5f6498d fix: do not mutate ipc instances across contexts (#23240)
  • e3c1292 fix: block custom window.open when nativeWindowOpen is true (#23188) (#23225)
  • b3e5383 fix: do not allow child windows to specify their own preload script (#23230)
  • f3e9f10 fix: ensure that functions are not retained beyond their context being releas...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 7, 2020
@coveralls
Copy link

coveralls commented Jul 7, 2020

Coverage Status

Coverage remained the same at 53.277% when pulling fe65126 on dependabot/npm_and_yarn/Composer/electron-8.2.4 into 182f422 on master.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/Composer/electron-8.2.4 branch from 7a96a68 to 369fd9f Compare July 7, 2020 09:22
@cwhitten
Copy link
Member

cwhitten commented Jul 7, 2020

@tonyanziano is this version of electron approved?

@tonyanziano
Copy link
Contributor

@cwhitten I'll look into it

@tonyanziano
Copy link
Contributor

tonyanziano commented Jul 7, 2020

We don't use either of the APIs addressed by this security vulnerability, so I think we can close this. However, if we need to resolve this alert to remain compliant then there is a Microsoft-approved build we can bump to.

@tonyanziano tonyanziano changed the title chore(deps-dev): bump electron from 8.0.2 to 8.2.4 in /Composer chore: bump electron from 8.0.2 to 8.2.4 in /Composer Jul 7, 2020
@tonyanziano tonyanziano merged commit 9104afd into master Jul 7, 2020
@tonyanziano tonyanziano deleted the dependabot/npm_and_yarn/Composer/electron-8.2.4 branch July 7, 2020 18:28
@cwhitten cwhitten mentioned this pull request Jul 8, 2020
GeoffCoxMSFT added a commit that referenced this pull request Jul 10, 2020
* fix: add logo-clicking to tests (#3500)

* add logo-clicking to tests

* bump elliptic version

* Update yarn.lock

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* feat: support validate lg custom functions (#3273)

* fix: support validate lg custom functions and separate the dialog validation from parser

* use file name as namespace

* add unit test

* fix lint

* fix: inline editing LU mess up whole file (#3478)

* upgrade lu packages

* update package

* clean

* update

* clean up

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* refactor: change term primary key to authoring key (#3516)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* fix: replace the endpoint to authoringEndpoint when publishing luis (#3517)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* propagate code editor settings to all editor surfaces (#3520)

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* run coverage on all source files (#3522)

without this config, jest would only collect coverage on files that were imported in a test

* feat: add loading indicator when waiting on form data or schema to load (#3523)

* move AdaptiveForm components out of sub directory

* show loading spinner while waiting for form data and schema

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* feat: allow inputting path (#3302)

* allow input path

* handle corner case

* lint fix

* fix the flicker issue

* update UX and create or update folder operation

* refine code structure

* remove commented code

* fix unit test

* use esc to cancel operation

* handle comments

* handle comments

* add test case

* fix test case

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* chore: Index file renames part 1 (#3519)

* Renamed components, hooks, Onboarding only

* Reverting changed from yar build

* Renamed components, hooks, Onboarding only

* Reverting changed from yar build

* Fixing lint issues

* test import fixes

* Have to rename to fix case of file name

* Fixing case with another commit.

* Renamed components, hooks, Onboarding only

* Renamed components, hooks, Onboarding only

* Fixing lint issues

* test import fixes

* Have to rename to fix case of file name

* Fixing case with another commit.

* Fixing imports

* test: increase 'adaptive-flow' test coverage to 77% (#3530)

* + UT: adaptive-flow-renderer/widgets

* + UT: adaptive-flow-editor/utils

* remove unref hook: useWindowDimension

* + UT: KeyboardZone

* + UT: cursorTracker

* + UT: adaptive-flow-editor/constants

* +UT: AdaptiveFlowEditor

* + UT: adaptive-flow-editor/contexts

* + UT: useEditorEventApi

* fix CI error

* + UT: NodeWrapper

* + UT: EdgeMenu

* KeyboardZone behavioror test

* change the test file structure of cursorTracker

* update a test case (#3531)

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix lgWorker test failure (#3529)

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* chore: adds webpack bundle analyzer (#3542)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

* fix: #3485

* fix: #3486 Debug/Fix HMR support

* webpack bundle analyzer

Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>

* refactor: split some actions off setSettings (#3525)

* split some actions off setSettings

* add more actions - eject still not working

* fix arguments in eject

* split some actions off setSettings

* add more actions - eject still not working

* fix arguments in eject

* Update setting.ts

* fix some tests

* Update index.ts

* move logo-clicking to commands.ts

* Update commands.ts

* fix: Dialog validate throw error when delete an action (#3537)

* fix: Dialog validate throw error when delete an action

* use optional chaining and more explicit length check

* fix lint

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>

* fix: composer will crashed when add a new publish profile (#3550)

* replace function callbacks with arrows (#3545)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* fix: location initialization (#3549)

* fix bug

* fix e2e test

* fix bug

* chore: Index file renames part 2 (#3546)

* Renamed components, hooks, Onboarding only

* Reverting changed from yar build

* Renamed components, hooks, Onboarding only

* Reverting changed from yar build

* Fixing lint issues

* test import fixes

* Have to rename to fix case of file name

* Fixing case with another commit.

* Renamed components, hooks, Onboarding only

* Renamed components, hooks, Onboarding only

* Fixing lint issues

* test import fixes

* Have to rename to fix case of file name

* Fixing case with another commit.

* Fixing imports

* Index file renames Part 2

* fix: deploy issue while zipping the folder (#3557)

* move bot-deploy to plugins

* fix profile edit and save not saving to settings

* add dependency to electron-server

* update settings file clicking customized runtime toggle

Co-authored-by: Wenyi Luo <wenyluo@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>

* docs: archive old docs (#3572)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* chore(deps-dev): bump electron from 8.0.2 to 8.2.4 in /Composer (#3577)

Bumps [electron](https://github.com/electron/electron) from 8.0.2 to 8.2.4.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md)
- [Commits](electron/electron@v8.0.2...v8.2.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tony Anziano <toanzian@microsoft.com>

* Bumped electron-builder config to correct electron version. (#3584)

* doc: add some missing details to plugin readme (#3585)

* handle schema parsing error better (#3586)

* fix nodemon `--inspect` error in lgWorker (#3590)

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* feat: Disable / Enable actions (#3416)

* impl disable/enable editor API

* disable / enable e2e

* propagate the 'disabled' property

* take css out of CardTemplate

* take css out of ActionHeader

* connect to the 'disabled' property in data

* CSS: disbaled effect

* update icon of Disabled/Enabled

* rename inheritParentProperty

* shallow copy json in IndexedNode to support immutable

* rename files with  '.style' suffix

* apply disable effect to PromptWidget

* only disable nodes when disabled === true

* contextual Disable/Enable btn state

* move disable/enable button into toolbar

* avoid undefined array in UT

* release: 1.0.2 (#3595)

* Change versions

* Adds 1.0.2.md

* update uncategorized commits

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* chore: Moved styles inline for components in client package. (#3598)

* Renamed components, hooks, Onboarding only

* Reverting changed from yar build

* Renamed components, hooks, Onboarding only

* Reverting changed from yar build

* Fixing lint issues

* test import fixes

* Have to rename to fix case of file name

* Fixing case with another commit.

* Renamed components, hooks, Onboarding only

* Renamed components, hooks, Onboarding only

* Fixing lint issues

* test import fixes

* Have to rename to fix case of file name

* Fixing case with another commit.

* Fixing imports

* Index file renames Part 2

* Inlined styles in ts

* Fixed test mocks

* feat: grouping Toolbar buttons under the 'Edit' dropdown button (#3608)

* let ToolBar support 'dropdown' type

* move 'design' page only toolbar items into DesignPage

* migrate 'Add New Trigger' coachmark feature

* grouping 'Edit' buttons together as a dropdown

* loosen 'type' TS type in toolbar

* fix: Syntax error when creating a "Send a response" node (#3604)

* refine diagnostics

* fix lg parse line number range

* update inline diagnostic

* update test

* resue websocket connection

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* Merge from master with fixes

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
Co-authored-by: liweitian <liweitian93@outlook.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: zeye <2295905420@qq.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Wenyi Luo <wenyluo@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Yan Liu <32497439+zxyanliu@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tony Anziano <toanzian@microsoft.com>
Co-authored-by: Ben Brown <benbro@microsoft.com>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…osoft#3577)

Bumps [electron](https://github.com/electron/electron) from 8.0.2 to 8.2.4.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md)
- [Commits](electron/electron@v8.0.2...v8.2.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tony Anziano <toanzian@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants