Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check whether operation is under current project folder #4078

Merged
merged 6 commits into from
Sep 15, 2020
Merged

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Sep 10, 2020

Description

validate operation is under current project's folder.
validate .dialog and appsettings.json file content

Task Item

closes #3724

Screenshots

@coveralls
Copy link

coveralls commented Sep 10, 2020

Coverage Status

Coverage increased (+0.02%) to 55.516% when pulling 6c0f391 on bug3724 into c07ae13 on main.

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Sep 15, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit a78a8f4 into main Sep 15, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the bug3724 branch September 15, 2020 18:55
@a-b-r-o-w-n a-b-r-o-w-n restored the bug3724 branch September 15, 2020 18:55
@a-b-r-o-w-n a-b-r-o-w-n deleted the bug3724 branch September 15, 2020 18:55
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Sep 16, 2020
* main:
  fix: add more missing formatMessage calls (microsoft#4144)
  feat: electron splash screen (microsoft#4119)
  feat: Add QnA files to dispatch model in skill manifest (microsoft#3985)
  fix: check whether operation is under current project folder (microsoft#4078)
  update localization and add missing "example" string (microsoft#4138)
  fix: defense invocation of `value.match()` (microsoft#4110)
  fix: checkReturnType in ExpressionValidation throws unexpected error (microsoft#4112)
  chore(deps): Bump tree-kill from 1.2.1 to 1.2.2 in /Composer (microsoft#4035)
  build: fix docker builds in ACR (microsoft#3986)
  fix: security: downgrade node-forge to 0.9.0 (microsoft#4133)
  chore: update archiver to fix security warning (microsoft#4116)
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…ft#4078)

* check whether operation is under current project folder

* fix test case

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Composer allows files to be written outside the current bot project
4 participants