fix: defense the usage of 'match()' method in skillsUtils #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
|
@tonyanziano @srinaath can you help take a look at this one? |
boydc2014
approved these changes
Sep 15, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Sep 16, 2020
* main: fix: add more missing formatMessage calls (microsoft#4144) feat: electron splash screen (microsoft#4119) feat: Add QnA files to dispatch model in skill manifest (microsoft#3985) fix: check whether operation is under current project folder (microsoft#4078) update localization and add missing "example" string (microsoft#4138) fix: defense invocation of `value.match()` (microsoft#4110) fix: checkReturnType in ExpressionValidation throws unexpected error (microsoft#4112) chore(deps): Bump tree-kill from 1.2.1 to 1.2.2 in /Composer (microsoft#4035) build: fix docker builds in ACR (microsoft#3986) fix: security: downgrade node-forge to 0.9.0 (microsoft#4133) chore: update archiver to fix security warning (microsoft#4116)
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the problem that given an undefined skill url, whole App will be crashed.
NOTE: This issue had been there for a while. Recently, some changes on skill made ErrorBoundary can't capture errors anymore and exposed this issue.
Task Item
closes #4109
Screenshots