chore: Update NodeJs Engine compat to v14, add pre-reqs to Composer readme #8225
Conversation
taicchoumsft
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
pavolum,
srinaath,
tdurnford,
tonyanziano and
yeze322
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -27,7 +27,7 @@ | |||
| "ejs": "^3.1.6" | |||
| }, | |||
| "engines": { | |||
| "node": ">=12" | |||
| "node": "14.x" | |||
There was a problem hiding this comment.
@taicchoumsft Im assuming the build broke with Node 16, hence you are avoiding the usage of >=14?
There was a problem hiding this comment.
Yes, this is the error from bf-orchestrator when running yarn install on Node V16.4.0:
error @microsoft/bf-orchestrator@4.13.0-rc0: The engine "node" is incompatible with this module. Expected version "^10.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0". Got "16.4.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
I just created a ticket to track this on cli side: cli#1258
|
|
||
| OS | Version | Architectures | ||
| ------------------|--------------------|--------------- | ||
| Mac OS X | 10.14+ | x64 |
There was a problem hiding this comment.
should we note something about M1 (arm) version?
There was a problem hiding this comment.
Thanks @hatpick , added a sentence explicitly mentioning we don't run on M1 hardware.
Description
Update Node Version to V14. V16 is not supported yet by bf-cli (via orchestratorlib), and we've dropped support for Node V12 and below (via Antlr 4.9.2 in bf-lu)
Also update all our docs on this site to mention we only support building Composer on NodeV14 for now. @JonathanFingold has already done the accompanying update on the docs site here
Also add build pre-reqs to our README as a source of truth for docs.
Task Item
closes #8211