Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Adaptive Cards to 2.* #3392

Closed
compulim opened this issue Aug 7, 2020 · 2 comments · Fixed by #3630
Closed

Bump Adaptive Cards to 2.* #3392

compulim opened this issue Aug 7, 2020 · 2 comments · Fixed by #3630
Assignees
@corinagum
Labels
feature-request Azure report label p0 Must Fix. Release-blocker
Milestone
R12

Comments

@compulim
Copy link
Contributor

compulim commented Aug 7, 2020 •
edited
Loading

Feature Request

https://www.npmjs.com/package/adaptivecards

There are a few breaking changes we will need to modify code on our side to support them.

Adaptive Cards renderer 2.1 is using schema of 1.3, not 2.x.

Ping service team

Service team may need to update their service code or dependencies to make sure their parser/stringifier support AC schema 1.3.

Today, when a bot send AC JSON to Direct Line channel, the channel parse, then restringify it. Then, they send it to Web Chat.

When we bump to AC 2.*, if the service is not ready for AC with schema 1.3, it may not be very meaningful (other than accessibility fixes).

[Enhancement]
@compulim compulim added this to the R11 milestone Aug 10, 2020
@compulim compulim mentioned this issue Sep 2, 2020
Closed
@corinagum corinagum self-assigned this Sep 11, 2020
@corinagum corinagum added feature-request Azure report label and removed Enhancement feature-request Azure report label labels Sep 23, 2020
@corinagum corinagum modified the milestones: R11, Needs-scheduling Oct 2, 2020
@corinagum
Copy link
Contributor

corinagum commented Oct 2, 2020 •
edited
Loading

@Jeffders @p-nagpal FYI. punting out of R11

@compulim compulim added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Oct 5, 2020
@corinagum corinagum modified the milestones: Needs-scheduling, R12 Oct 28, 2020
@corinagum corinagum removed backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner labels Oct 28, 2020
@corinagum corinagum mentioned this issue Nov 4, 2020
Closed
@corinagum
Copy link
Contributor

This bump will fix the bug brought up in #3111 (reference: microsoft/AdaptiveCards#3829)

@compulim compulim mentioned this issue Nov 5, 2020
Closed
@corinagum corinagum added the p0 Must Fix. Release-blocker label Nov 9, 2020
@corinagum corinagum mentioned this issue Dec 8, 2020
Merged
10 tasks
This was referenced Mar 2, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
feature-request Azure report label p0 Must Fix. Release-blocker
Projects
None yet
Milestone
R12
Development

Successfully merging a pull request may close this issue.

Bump adaptivecards@2.5.0 corinagum/BotFramework-WebChat
2 participants
@compulim @corinagum