-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump adaptivecards@2.5.0 #3630
Merged
Merged
Bump adaptivecards@2.5.0 #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
beyackle,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
December 8, 2020 01:07
amal-khalaf
approved these changes
Dec 9, 2020
cwhitten
reviewed
Dec 9, 2020
packages/bundle/src/adaptiveCards/Attachment/ReceiptCardContent.js
Outdated
Show resolved
Hide resolved
corinagum
force-pushed
the
3392-ACBump
branch
from
December 10, 2020 21:26
a81cad4
to
bbbcab2
Compare
/azp run |
No pipelines are associated with this pull request. |
This was referenced Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
Bump Adaptive Cards to use latest SDK version. Breaking changes list can be found at https://github.com/microsoft/AdaptiveCards/blob/f18d76e516dcb43b90f6587028f18747dd1bfbe2/source/nodejs/adaptivecards/README.md#breaking-changes
With this bump, the following will be displayed when an Adaptive Card schema of 1.3 (or other) is sent:
This is due to the service not yet supporting the 1.3 schema.
This message is from the Adaptive Cards sdk
MockBot has two new cards:
agenda
andwizard
All previously working Adaptive Cards have been verified with this bump
tests__/html/cardAction.adaptiveCard.cardAgendaTranscript.html
is an example of a 1.3 schema card working in Web Chat (not using DirectLine service)Tests image diffs updated
There are a number of tests that had to be updated with this bump. I have verified the behavior as either a fix of Adaptive Cards behavior, regression (with corresponding issue), or trivial changes due to MockBot updates.
'adaptive cards broken card of invalid version'
This error message is from the Adaptive Cards sdk
This is a change in behavior to what should be expected. Broken card should show an error, not show an empty div.
'useScrollToEnd calling scroll to end should scroll to end'
There are a number of scrollbar fixes (due to length of transcript)that are caused by adding new commands to MockBot. This is not a change in behavior.
'clock skew - faking clock skew should affect activity order'
Previously, images were not center-aligned even though MockBot's BingSports card indicates it. Fixed by Adaptive Cards bump.
'adaptive cards disable card inputs'
This is a behavior bug from Adaptive Cards, seen at microsoft/AdaptiveCards#5134 This PR shows the change as fixed, and therefore should be fixed in the next AC release/bump. This will eventually mean updating the snapshots again.
'transcript activity grouping'
These screenshots are additions, not changes. I'm assuming they are new tests that didn't have snapshots pushed up in a previous commit. I am assuming the behavior in these screenshots is as expected
CHANGELOG.md
[ ] I have updated documentationReview Checklist
z-index
)package.json
andpackage-lock.json
reviewed