Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added botAvatarBackgroundColor and userAvatarBackgroundColor to the default style options #2384

Merged
merged 5 commits into from
Sep 11, 2019
Merged

Added botAvatarBackgroundColor and userAvatarBackgroundColor to the default style options #2384

merged 5 commits into from
Sep 11, 2019

Conversation

tdurnford
Copy link
Contributor

@tdurnford tdurnford commented Sep 6, 2019 •
edited
Loading

Fixes #2380
Fixes #2306

Changelog Entry

  • Fix #2380. Added botAvatarBackgroundColor and userAvatarBackgroundColor to the default style options, by @tdurnford in PR #2384

Description

Added botAvatarBackgroundColor and userAvatarBackgroundColor to the default style options. When either is null respectively the avatar background color is the accent color.

const styleOptions = {
  botAvatarBackgroundColor: 'red',
  botAvatarInitials: 'B',
  userAvatarBackgroundColor: 'blue',
  userAvatarInitials: 'TJ',

  suggestedActionBorderWidth: 4,
  suggestedActionBorderColor: 'silver',
  suggestedActionBorderStyle: 'double',

  suggestedActionDisabledBorderWidth: 1,
  suggestedActionDisabledBorderColor: 'blue',
  suggestedActionDisabledBorderStyle: 'dashed'
};

image

  • Testing Added

compulim
compulim approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

packages/component/src/Styles/defaultStyleOptions.js Outdated Show resolved Hide resolved
@tdurnford tdurnford changed the title Added botAvatarBackgroundColor and userAvatarBackgroundColor to the default style options [Do not merge] Added botAvatarBackgroundColor and userAvatarBackgroundColor to the default style options Sep 6, 2019
@tdurnford tdurnford changed the title [Do not merge] Added botAvatarBackgroundColor and userAvatarBackgroundColor to the default style options Added botAvatarBackgroundColor and userAvatarBackgroundColor to the default style options Sep 9, 2019
@corinagum
Copy link
Contributor

@compulim ping, did all your change requests make it in?

@tdurnford tdurnford mentioned this pull request Sep 10, 2019
Closed
@corinagum corinagum merged commit 7da2850 into microsoft:master Sep 11, 2019
This was referenced Sep 27, 2019
Closed
Closed
Closed
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum left review comments

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BOT Avatar has a blue circle background No option to change font size in defaultStyleOptions.js
3 participants
@tdurnford @corinagum @compulim