Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving Issue 1904 #2439

Closed
wants to merge 12 commits into from
Closed

Conversation

reyesrico
Copy link

Fixes #1904

Changelog Entry

Adding new styleOptions for user and bot avatars.

Description

Adding new styleOptions for user and bot avatars:
botAvatarBackgroundColor, botAvatarBorderRadius, botAvatarFont, botAvatarFontSize, botAvatarTextColor, userAvatarBackgroundColor, userAvatarBorderRadius, userAvatarFont, userAvatarFontSize, userAvatarTextColor.

Specific Changes

Updated Avatar (Activity and StyleSet components) and defaultStyleOptions files to receive new styleOptions params. Also it was updated index.html from samples/04.a

  • Testing Added
    Updated index.html from samples/04.a

@msftclas
Copy link

msftclas commented Oct 3, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ reyesrico sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@tdurnford
Copy link
Contributor

tdurnford commented Oct 3, 2019

I think this issue was already fixed in #2384.

@corinagum
Copy link
Contributor

Carlos! Why is this PR 100+ files?? xD

@corinagum
Copy link
Contributor

@reyesrico
Carlitos, I'm going to close this PR, since we already have the code implemented. There are 1 or 2 pieces missing though, so let's resume conversation on #1904.

@corinagum
Copy link
Contributor

See #2447

@corinagum corinagum closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bot/User Avatar Initials Text and Background Color to defaultStyleOptions
5 participants