Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React hooks for customization (part 1) #2540

Merged
merged 7 commits into from
Nov 7, 2019
Merged

Add React hooks for customization (part 1) #2540

merged 7 commits into from
Nov 7, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 1, 2019 •
edited
Loading

Related to #2539.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim and @corinagum, in the following PRs:
    • PR #2540: useActivities, useReferenceGrammarID, useSendBoxDictationStarted

Description

Add useActivities, useReferenceGrammarID and useSendBoxDictationStarted.

Specific Changes

  • Test harness
    • Added runHook function
  • Exporting hooks
  • Added the following hooks:
    • useActivities
    • useReferenceGrammarID
    • useSendBoxDictationStarted
  • Updated components to use forementioned hooks
  • Renamed Context to WebChatUIContext
  • Removed unnecessary HOC for <ScreenReaderText>
  • Updated WebChatReduxContext to export custom Redux hooks (this is not publicly exporting)
  • Updated sample 21 to use aforementioned hooks
  • Testing Added

@coveralls
Copy link

coveralls commented Nov 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 63.407% when pulling 7b56c4c on compulim:feat-redux-hooks-1 into c4a5852 on microsoft:master.

This was referenced Nov 2, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
tdurnford
tdurnford approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit ef38aa4 into microsoft:master Nov 7, 2019
@compulim compulim deleted the feat-redux-hooks-1 branch November 7, 2019 01:36
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks
4 participants
@compulim @coveralls @tdurnford @corinagum