Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React Hooks for customization (part 8) #2549

Merged
merged 4 commits into from
Nov 21, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 4, 2019

Related to #2539.

Please merge #2540, #2541, #2542, #2543, #2544, #2547 and #2548 before reviewing this one.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim, in the following PRs:
    • PR #2540: useActivities, useReferenceGrammarID, useSendBoxDictationStarted
    • PR #2541: useStyleOptions, useStyleSet
    • PR #2542: useLanguage, useLocalize, useLocalizeDate
    • PR #2543: useAdaptiveCardsHostConfig, useAdaptiveCardsPackage, useRenderMarkdownAsHTML
    • PR #2544: useAvatarForBot, useAvatarForUser
    • PR #2547: useEmitTypingIndicator, usePeformCardAction, usePostActivity, useSendEvent, useSendFiles, useSendMessage, useSendMessageBack, useSendPostBack
    • PR #2548: useDisabled
    • PR #2549: useSuggestedActions

Description

Add several post message related hooks:

  • useSuggestedActions

Specific Changes

  • Added the following hooks:
    • useSuggestedActions
  • Updated components to use aforementioned hooks

  • Testing Added

@coveralls
Copy link

coveralls commented Nov 4, 2019

Coverage Status

Coverage decreased (-0.008%) to 64.04% when pulling 747a923 on compulim:feat-redux-hooks-8 into a2bb227 on microsoft:master.


jest.setTimeout(timeouts.test);

test('getter should get suggested actions', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test for setting suggested actions?

Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corinagum
Copy link
Contributor

@compulim this has eslint errors. Please fix.

@corinagum corinagum merged commit 7e00491 into microsoft:master Nov 21, 2019
@corinagum corinagum deleted the feat-redux-hooks-8 branch November 21, 2019 21:45
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks
4 participants