-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suggested actions flow layout #3641
Merged
compulim
merged 6 commits into
microsoft:master
from
compulim:feat-suggested-actions-inline
Dec 24, 2020
Merged
Add suggested actions flow layout #3641
compulim
merged 6 commits into
microsoft:master
from
compulim:feat-suggested-actions-inline
Dec 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
December 15, 2020 23:41
corinagum
reviewed
Dec 18, 2020
corinagum
changed the title
Add suggested actions inline layout
Add suggested actions float layout
Dec 18, 2020
corinagum
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, + don't forget to rename to flow instead of inline. LGTM!
compulim
force-pushed
the
feat-suggested-actions-inline
branch
from
December 22, 2020 19:44
a87c999
to
7c14c83
Compare
compulim
changed the title
Add suggested actions float layout
Add suggested actions flow layout
Dec 22, 2020
When will this be released? Also what is the exact usage? e.g. |
6 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
flow
layout to suggested actions, by @compulim in PR #3641Description
Added a new layout to suggested action:
inline
. And a new option to curb the height of the container and make it scrollable:suggestedActionsInlineMaxHeight
.Specific Changes
SuggestedActions.js
, and refactoredSuggestedAction.js
to use non-flexbox for laying out images inside buttonsstyleOptions
:flow
option tosuggestedActionLayout
suggestedActionsInlineMaxHeight
CHANGELOG.md
I have updated documentationReview Checklist
z-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)