Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra padding by empty flow layout #3748

Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 22, 2021

Fixes #3746.

Changelog Entry

Added

(Updated the entry with PR number)

Description

An unnecessary padding was introduced when using "flow" layout in suggested actions.

Design

Add a flow-box and only show it when there is any suggested actions.

Specific Changes

  • Modify SendBox/suggestedActions.js to add a flow-box component
  • Modify Styles/suggestedActions.js to move styles to the flow-box
  • Add VRT to make sure after a suggested action is selected, the layout is correct
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum added this to the R12 milestone Feb 23, 2021
@corinagum corinagum merged commit 94ed59b into microsoft:master Feb 23, 2021
@compulim compulim mentioned this pull request Mar 2, 2021
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants