Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML tests: fix accessibility issues in HTML files #4685

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Mar 22, 2023

Related to #4650. Fixed #4665.

Changelog Entry

Added

  • Related to #4650. Added automated accessibility check using axe-core
    • HTML test: fix accessibility issues on HTML file, by @compulim, in PR #4685

Fixed

Description

Fixed some accessibility issues related to the HTML files which contains our tests.

Also fixed issues after we bump ESBuild.

TODO

  • autoScroll.withPostBack.activity.html: AC Input.ChoiceSet should use label attribute, than a TextBlock element
  • autoScroll.withPostBack.page.html: AC Input.ChoiceSet should use label attribute, than a TextBlock element

Design

Specific Changes

  • Injected <header> to test files
  • Injected document.title
  • Updated transcript to include image alt text for transcript navigation tests
  • Fixed development server to works with latest ESBuild
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review March 22, 2023 23:20
@compulim compulim added this to the imminent milestone Mar 22, 2023
@compulim compulim marked this pull request as draft March 22, 2023 23:23
@compulim compulim added the p1 Painful if we don't fix, won't block releasing label Mar 23, 2023
@compulim compulim marked this pull request as ready for review March 23, 2023 18:23
tdurnford
tdurnford previously approved these changes Mar 28, 2023
@compulim compulim force-pushed the feat-html-test-accessibility branch from 265351a to 8931e6c Compare April 5, 2023 23:55
@compulim compulim merged commit 9f00e6c into main Apr 6, 2023
@compulim compulim deleted the feat-html-test-accessibility branch April 6, 2023 03:15
@compulim compulim mentioned this pull request Apr 12, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm start not working after bumping ESBuild
2 participants