-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add axe-core
and fix tests
#4704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
srinaath,
tdurnford and
beyackle2
as code owners
April 12, 2023 17:44
tdurnford
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
activity.channelData['webchat:fallback-text']
is present but empty, it will no longer appliesaria-hidden
to the activityactivityMiddleware
to customize the renderingAdded
axe-core
axe-core
in end-to-end tests, by @compulim, in PR #4704<main>
for the root container, by @compulim, in PR #4684 and PR #4704ponyfill
prop to<ReactWebChat>
/<Composer>
andcreateStoreWithOptions
, by @compulim, in PR #4662role
attribute, by @compulim, in PR #4704<header>
container, by @compulim, in PR #4704<label>
for input fields in Adaptive Cards, by @compulim, in PR #4704Description
Add accessibility checker (
axe-core
) in our end-to-end tests and runs it after taking every screenshots and before completion of the test.Design
Specific Changes
axe-core
aswindow.checkAccessibility()
and run after everyhost.snapshot()
andhost.done()
activity.channelData['webchat:fallback-text']
is empty, it will no longer setaria-hidden
role
attribute toform
if it has any input fields and is valid as aform
, otherwise,figure
<iframe>
<header>
as it is "page header" but not "dialog header"<main>
is on every testCHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)