Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent: sendbox transcript navigation #5191

Merged
merged 5 commits into from
May 28, 2024

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented May 20, 2024

Fixes #5153

Changelog Entry

  • Added missing support for chat history scroll with keyboard when Fluent send box is focused, in PR 5191, by @OEvgeny

Description

This adds necessary handlers for transcript navigation into Fluent SendBox for feature parity with white label experience.

Design

Took this as an opportunity to reduce context usage. The subscriptions are now handled via use-paginate.

This adds the new useTranscriptNavigation private hook which currently returns only the keydown event handler, but can be further extended in the future. The handler is designed to be placed in the send box root and is intended to handle only usage patterns seen in the send box.

Specific Changes

  • Reworked useScrollRelative and useRegisterScrollRelative
  • Added transcript scroll with keyboard support into Fluent SendBox component
  • Added tests
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny requested a review from compulim May 28, 2024 19:01
@compulim compulim merged commit 7ced5fa into main May 28, 2024
25 checks passed
@compulim compulim deleted the fix/fluent-sendbox-transcript-navigation branch May 28, 2024 20:29
OEvgeny added a commit that referenced this pull request May 30, 2024
* Fluent: allow transcript scroll when sendbox focused

* Rework empty check

* Fix failing tests

* Changelog

---------

Co-authored-by: William Wong <compulim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fluent UI] Keyboard navigational keys not working on send box
2 participants