-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent: sendbox transcript navigation #5191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
May 20, 2024 19:20
11 tasks
compulim
reviewed
May 28, 2024
compulim
approved these changes
May 28, 2024
OEvgeny
added a commit
that referenced
this pull request
May 30, 2024
* Fluent: allow transcript scroll when sendbox focused * Rework empty check * Fix failing tests * Changelog --------- Co-authored-by: William Wong <compulim@users.noreply.github.com>
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 8, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
This adds necessary handlers for transcript navigation into Fluent SendBox for feature parity with white label experience.
Design
Took this as an opportunity to reduce context usage. The subscriptions are now handled via
use-paginate
.This adds the new
useTranscriptNavigation
private hook which currently returns only thekeydown
event handler, but can be further extended in the future. The handler is designed to be placed in the send box root and is intended to handle only usage patterns seen in the send box.Specific Changes
useScrollRelative
anduseRegisterScrollRelative
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)