Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove keyboard helper screen from web chat #5234

Merged
merged 11 commits into from
Aug 15, 2024
Merged

remove keyboard helper screen from web chat #5234

merged 11 commits into from
Aug 15, 2024

Conversation

amirmursal
Copy link
Contributor

@amirmursal amirmursal commented Jul 2, 2024

Fix candidate for #5220, #5212, #4965, #4918

Changelog Entry

Fixes #4965. Removed keyboard helper screen in #5234, by @amirmursal

Description

Removed keyboard control screen from the chat window to address several accessibility issues

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

beyackle2
beyackle2 previously approved these changes Jul 8, 2024
Copy link
Collaborator

@OEvgeny OEvgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update tests according to my comment

@OEvgeny OEvgeny self-requested a review July 9, 2024 17:03
OEvgeny
OEvgeny previously approved these changes Jul 9, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@OEvgeny
Copy link
Collaborator

OEvgeny commented Jul 29, 2024

We probably want to cleanup localizations as well:

"KEYBOARD_HELP_CHAT_HISTORY_ACCESS_ITEMS_IN_MESSAGE_BODY": "Enter key",
"KEYBOARD_HELP_CHAT_HISTORY_ACCESS_ITEMS_IN_MESSAGE_HEADER": "Access items in message",
"KEYBOARD_HELP_CHAT_HISTORY_HEADER": "Chat history",
"KEYBOARD_HELP_CHAT_HISTORY_LEAVE_MESSAGE_BODY": "Escape key",
"KEYBOARD_HELP_CHAT_HISTORY_LEAVE_MESSAGE_HEADER": "Exit message",
"_KEYBOARD_HELP_CHAT_HISTORY_LEAVE_MESSAGE_HEADER.comment": "While focus is on the message, when the user press ESCAPE key, it should exit the message focus mode and focus back on the text box in the send box.",
"KEYBOARD_HELP_CHAT_HISTORY_MOVE_BETWEEN_ITEMS_BODY": "Tab key\nShift + tab key",
"KEYBOARD_HELP_CHAT_HISTORY_MOVE_BETWEEN_ITEMS_HEADER": "Move between items in a message",
"KEYBOARD_HELP_CHAT_HISTORY_MOVE_BETWEEN_MESSAGES_BODY": "Arrow up key\nArrow down key",
"KEYBOARD_HELP_CHAT_HISTORY_MOVE_BETWEEN_MESSAGES_HEADER": "Move between messages",
"KEYBOARD_HELP_CHAT_WINDOW_BODY_DO_ACTION_BODY": "Enter key",
"KEYBOARD_HELP_CHAT_WINDOW_BODY_DO_ACTION_HEADER": "Do action",
"KEYBOARD_HELP_CHAT_WINDOW_BODY_MOVE_BETWEEN_ITEMS_BODY": "Tab key\nShift + tab key",
"KEYBOARD_HELP_CHAT_WINDOW_BODY_MOVE_BETWEEN_ITEMS_HEADER": "Move between items in the chat window",
"KEYBOARD_HELP_CHAT_WINDOW_HEADER": "Chat window",
"KEYBOARD_HELP_CLOSE_BUTTON_ALT": "Close",
"KEYBOARD_HELP_HEADER": "Keyboard controls",

@OEvgeny
Copy link
Collaborator

OEvgeny commented Aug 15, 2024

We probably want to cleanup localizations as well:

"KEYBOARD_HELP_CHAT_HISTORY_ACCESS_ITEMS_IN_MESSAGE_BODY": "Enter key",
"KEYBOARD_HELP_CHAT_HISTORY_ACCESS_ITEMS_IN_MESSAGE_HEADER": "Access items in message",
"KEYBOARD_HELP_CHAT_HISTORY_HEADER": "Chat history",
"KEYBOARD_HELP_CHAT_HISTORY_LEAVE_MESSAGE_BODY": "Escape key",
"KEYBOARD_HELP_CHAT_HISTORY_LEAVE_MESSAGE_HEADER": "Exit message",
"_KEYBOARD_HELP_CHAT_HISTORY_LEAVE_MESSAGE_HEADER.comment": "While focus is on the message, when the user press ESCAPE key, it should exit the message focus mode and focus back on the text box in the send box.",
"KEYBOARD_HELP_CHAT_HISTORY_MOVE_BETWEEN_ITEMS_BODY": "Tab key\nShift + tab key",
"KEYBOARD_HELP_CHAT_HISTORY_MOVE_BETWEEN_ITEMS_HEADER": "Move between items in a message",
"KEYBOARD_HELP_CHAT_HISTORY_MOVE_BETWEEN_MESSAGES_BODY": "Arrow up key\nArrow down key",
"KEYBOARD_HELP_CHAT_HISTORY_MOVE_BETWEEN_MESSAGES_HEADER": "Move between messages",
"KEYBOARD_HELP_CHAT_WINDOW_BODY_DO_ACTION_BODY": "Enter key",
"KEYBOARD_HELP_CHAT_WINDOW_BODY_DO_ACTION_HEADER": "Do action",
"KEYBOARD_HELP_CHAT_WINDOW_BODY_MOVE_BETWEEN_ITEMS_BODY": "Tab key\nShift + tab key",
"KEYBOARD_HELP_CHAT_WINDOW_BODY_MOVE_BETWEEN_ITEMS_HEADER": "Move between items in the chat window",
"KEYBOARD_HELP_CHAT_WINDOW_HEADER": "Chat window",
"KEYBOARD_HELP_CLOSE_BUTTON_ALT": "Close",
"KEYBOARD_HELP_HEADER": "Keyboard controls",

Done

@OEvgeny OEvgeny requested a review from beyackle2 August 15, 2024 16:26
@OEvgeny OEvgeny enabled auto-merge (squash) August 15, 2024 16:27
@OEvgeny OEvgeny merged commit 0f4674e into main Aug 15, 2024
25 checks passed
@OEvgeny OEvgeny deleted the keyboardScreen branch August 15, 2024 21:53
@OEvgeny
Copy link
Collaborator

OEvgeny commented Aug 22, 2024

Closes #4995
Closes #4996
Closes #4997
as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talkback focus is moving to the invisible "Keyboard control" section present under "Transcript section.
4 participants