-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove keyboard helper screen from web chat #5234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update tests according to my comment
__tests__/html/transcript.navigation.visualKeyboardIndicator.html
Outdated
Show resolved
Hide resolved
We probably want to cleanup localizations as well: BotFramework-WebChat/packages/api/src/localization/en-US.json Lines 74 to 90 in e069c62
|
Co-authored-by: Eugene <EOlonov@gmail.com>
b8cdfc7
to
3ee5239
Compare
Done |
Changelog Entry
Fixes #4965. Removed keyboard helper screen in #5234, by @amirmursal
Description
Removed keyboard control screen from the chat window to address several accessibility issues
CHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)