-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish blueprint mode of pre-chat starter prompts #5279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
WIP: Polish
Polish blueprint mode of pre-chat starter prompts
Sep 6, 2024
uiState
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
September 6, 2024 03:28
OEvgeny
reviewed
Sep 6, 2024
packages/fluent-theme/src/components/preChatActivity/StarterPromptsCardAction.module.css
Outdated
Show resolved
Hide resolved
OEvgeny
reviewed
Sep 6, 2024
packages/fluent-theme/src/components/preChatActivity/StarterPromptsCardAction.module.css
Outdated
Show resolved
Hide resolved
OEvgeny
reviewed
Sep 6, 2024
packages/fluent-theme/src/components/preChatActivity/StarterPromptsCardAction.module.css
Outdated
Show resolved
Hide resolved
…omptsCardAction.module.css Co-authored-by: Eugene <EOlonov@gmail.com>
…omptsCardAction.module.css Co-authored-by: Eugene <EOlonov@gmail.com>
…omptsCardAction.module.css Co-authored-by: Eugene <EOlonov@gmail.com>
OEvgeny
previously approved these changes
Sep 6, 2024
This reverts commit 350baff.
OEvgeny
approved these changes
Sep 6, 2024
OEvgeny
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some thinking... We should adjust:
&[aria-disabled='true'],
&:empty {
cursor: default;
row-gap: 14px;
}
to either:
&[aria-disabled='true'],
&:empty {
cursor: default;
}
&:empty {
row-gap: 14px;
}
Or update the row-gap
for the whole card UX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
This is continuation of #5276.
Polishes the blueprint of starter prompts and supports RTL in animation.
Specific Changes
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)