Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish blueprint mode of pre-chat starter prompts #5279

Merged
merged 13 commits into from
Sep 6, 2024

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 6, 2024

Changelog Entry

Added

Description

This is continuation of #5276.

Polishes the blueprint of starter prompts and supports RTL in animation.

Specific Changes

  • Corrected gaps between skeleton of title and subtitle
  • Updated animation to support RTL
  • Also fixed flakiness test related to upload
    • After upload and send, should wait for outgoing activities to be sent
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim changed the title Polish uiState WIP: Polish uiState Sep 6, 2024
@compulim compulim changed the title WIP: Polish uiState Polish blueprint mode of pre-chat starter prompts Sep 6, 2024
@compulim compulim marked this pull request as ready for review September 6, 2024 03:28
compulim and others added 6 commits September 5, 2024 20:57
…omptsCardAction.module.css

Co-authored-by: Eugene <EOlonov@gmail.com>
…omptsCardAction.module.css

Co-authored-by: Eugene <EOlonov@gmail.com>
…omptsCardAction.module.css

Co-authored-by: Eugene <EOlonov@gmail.com>
OEvgeny
OEvgeny previously approved these changes Sep 6, 2024
@compulim compulim enabled auto-merge (squash) September 6, 2024 18:42
Copy link
Collaborator

@OEvgeny OEvgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some thinking... We should adjust:

  &[aria-disabled='true'],
  &:empty {
    cursor: default;
    row-gap: 14px;
  }

to either:

  &[aria-disabled='true'],
  &:empty {
    cursor: default;
  }
  &:empty {
    row-gap: 14px;
  }

Or update the row-gap for the whole card UX

@compulim compulim merged commit daac793 into main Sep 6, 2024
25 checks passed
@compulim compulim deleted the feat-polish-ui-state-2 branch September 6, 2024 18:56
@compulim compulim mentioned this pull request Sep 6, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants