Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish uiState for gaps #5284

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Polish uiState for gaps #5284

merged 4 commits into from
Sep 6, 2024

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 6, 2024

Fixes #

Changelog Entry

Added

Description

Fixed wrong gaps in disabled mode.

Specific Changes

  • Starter prompts CSS to use normal gaps for disabled mode, only use different gaps for blueprint
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review September 6, 2024 19:05
OEvgeny
OEvgeny previously approved these changes Sep 6, 2024
@compulim compulim merged commit 7d07659 into main Sep 6, 2024
25 checks passed
@compulim compulim deleted the feat-polish-ui-state-3 branch September 6, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants