Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots should be generated at regular interval #1301

Closed
3 tasks done
jumaffre opened this issue Jun 16, 2020 · 1 comment · Fixed by #1510
Closed
3 tasks done

Snapshots should be generated at regular interval #1301

jumaffre opened this issue Jun 16, 2020 · 1 comment · Fixed by #1510
Assignees
Milestone

Comments

@jumaffre
Copy link
Contributor

jumaffre commented Jun 16, 2020

Just like signature transactions, snapshots should be generated at regular interval (either elapsed time or number of signatures).

The hash of the snapshot should be written to the (new) ccf.snapshots table so that the snapshot becomes endorsed by the leader node that has generated it.

Once generated, snapshots should be stored on disk and retrievable for when a new node joins the network.

  • 1. Generate snapshots on primary node at regular interval (based on a cchost CLI parameter)
  • 2. Store snapshot evidence in new ccf.snapshot_hash table
  • 3. Make snapshot generation asynchronous (snapshot generation takes time and it shouldn't block the thread on which it is started on)
@jumaffre jumaffre added this to the Snapshot milestone Jun 16, 2020
@jumaffre
Copy link
Contributor Author

I wonder how this intersect with the ledger chunking feature. On recovery, we will probably want to only pass the latest snapshot + the ledger suffix (i.e. ledger after the snapshot) to the recovery node. Perhaps a new ledger chunk could be created when a new snapshot is generated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant