Generate and store snapshots on primary node #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 16, 2020 18:09
added 2 commits
August 14, 2020 17:57
|
generate_snapshot@11720 aka 20200818.17 vs master ewma over 50 builds from 11303 to 11717 |
achamayou
reviewed
Aug 17, 2020
achamayou
reviewed
Aug 17, 2020
achamayou
reviewed
Aug 17, 2020
achamayou
reviewed
Aug 17, 2020
added 2 commits
August 18, 2020 09:29
jumaffre
commented
Aug 18, 2020
achamayou
reviewed
Aug 18, 2020
achamayou
approved these changes
Aug 18, 2020
added 2 commits
August 18, 2020 14:09
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves item 1. in #1301
The primary node now generates snapshots at regular interval, as specified by the
--snapshot-min-txcchostCLI parameter. The snapshots are stored on disk (in the--snapshot-dirfolder specific to each node).By default, snapshots are never generated (hence the new temporary
reconfiguration_snapshot_testwhich sets it to a low value on purpose). We don't do anything with the snapshot just yet, but it will get passed to new joiners by Raft.