-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async snapshot generation and evidence #1510
Merged
jumaffre
merged 33 commits into
microsoft:master
from
jumaffre:async_snapshot_generation
Aug 19, 2020
Merged
Async snapshot generation and evidence #1510
jumaffre
merged 33 commits into
microsoft:master
from
jumaffre:async_snapshot_generation
Aug 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
commented
Aug 19, 2020
jumaffre
commented
Aug 19, 2020
async_snapshot_generation@11756 aka 20200819.12 vs master ewma over 50 builds from 11354 to 11749 |
achamayou
reviewed
Aug 19, 2020
achamayou
reviewed
Aug 19, 2020
…nto async_snapshot_generation
…nto async_snapshot_generation
achamayou
approved these changes
Aug 19, 2020
achamayou
pushed a commit
to achamayou/CCF
that referenced
this pull request
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1301
We now generate snapshots asynchronously on the primary, so that the consensus thread is not immediately blocked when a snapshot needs to be generated (note that with 0 worker thread, the snapshot is still generated/serialised on the consensus thread). The evidence of the snapshot (i.e. hash of serialised snapshot) is now also stored in a new
ccf.snapshot_evidences
table.