-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move channel manager into node state #2780
Merged
eddyashton
merged 5 commits into
microsoft:main
from
eddyashton:shuffle_consensus_type_for_channel_manager
Jul 9, 2021
Merged
Move channel manager into node state #2780
eddyashton
merged 5 commits into
microsoft:main
from
eddyashton:shuffle_consensus_type_for_channel_manager
Jul 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuffle_consensus_type_for_channel_manager@28736 aka 20210708.26 vs main ewma over 20 builds from 28411 to 28722 Click to see table
|
jumaffre
reviewed
Jul 8, 2021
achamayou
approved these changes
Jul 8, 2021
This was referenced Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of #2775. The forwarder and node-to-node channels were owned by the enclave and passed to node state, but the enclave doesn't do anything with them. It makes more sense for them to be owned and constructed within the node state. To make that construction path a little cleaner, the
ConsensusType
in the configuration moves from the top-level to theconsensus::Configuration
struct.