Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fix: Move consenus_type check to where it is now defined #2829

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

eddyashton
Copy link
Member

I moved consensus_type in #2780, from a top-level argument to nested within the passed config.

This broke compilation, which tries to access an undefined variable, but only when ENABLE_BFT=OFF, which only happens in the release job. We should think about adding a regular build configuration which tests this flag, since every other build currently uses ENABLE_BFT=ON (and then runs tests on that BFT build).

@eddyashton eddyashton requested a review from a team July 21, 2021 15:40
@ghost
Copy link

ghost commented Jul 21, 2021

enable_bft_check_fix@29561 aka 20210721.26 vs main ewma over 20 builds from 29064 to 29539

Click to see table
build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_sgx_bft^ tpcc_sgx_bft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem CHAMP put (/s)^ CHAMP get (/s)^
29064 20210714.2 6720.43 9.29342e+07 3010.72 2.0854e+08 21531.2 1.74367e+07 4441.3 1.45532e+07 2591.27 9.57242e+06 2538.24 9.31027e+06 1729.62 8.52384e+06 1.34595e+06 3.61199e+07
29096 20210714.13 6135.55 9.10992e+07 2780.37 2.46813e+08 24111.9 1.7961e+07 4272.5 1.50774e+07 2670.53 9.31027e+06 2568.98 9.57242e+06 1732.51 8.52384e+06 1.33403e+06 3.61837e+07
29133 20210714.25 6116.72 9.08371e+07 2375.15 2.35278e+08 21756.5 1.71746e+07 4422.37 1.50774e+07 2625.98 1.32424e+07 2456.13 9.31027e+06 1726.25 8.2617e+06 1.35208e+06 3.69675e+07
29146 20210714.29 6400.85 9.31964e+07 2745.12 2.22171e+08 24031.2 1.74367e+07 4415.38 1.48153e+07 2624.75 9.57242e+06 2576.03 9.31027e+06 1747.47 8.52384e+06 1.34746e+06 3.61837e+07
29156 20210715.2 6590.28 9.21478e+07 2356.08 3.34107e+08 23541.7 1.74367e+07 4420.9 1.4291e+07 2635.82 9.57242e+06 2408.1 9.57242e+06 1736.42 1.03588e+07 1.31925e+06 3.50685e+07
29205 20210715.18 6702.41 9.16235e+07 2755.67 2.36851e+08 21477.1 1.71746e+07 4205.34 1.50774e+07 2646.89 1.27181e+07 2498.96 9.31027e+06 1738.46 8.78598e+06 1.35235e+06 3.62484e+07
29224 20210715.23 6647.92 9.18856e+07 2862.32 2.21647e+08 21306.1 1.74367e+07 4220.2 1.48153e+07 2679.07 9.83456e+06 2497.11 9.04813e+06 1754.51 8.52384e+06 1.32531e+06 3.54325e+07
29237 20210716.2 6830.84 9.13613e+07 3203.15 1.67121e+08 20761.1 1.82232e+07 4024.93 1.45532e+07 2443.06 9.31027e+06 2519.76 9.57242e+06 1761 1.00967e+07 1.3162e+06 3.58669e+07
29238 20210716.3 6482.82 9.16235e+07 3004.58 2.01724e+08 22951 1.74367e+07 4310.86 1.50774e+07 2699.28 9.57242e+06 2550.97 9.83456e+06 1742.46 8.52384e+06 1.31139e+06 3.54939e+07
29245 20210716.5 6805.55 9.21478e+07 3198.66 2.11685e+08 21358.8 1.7961e+07 4233.33 1.50774e+07 2687.98 9.57242e+06 2582.58 9.57242e+06 1816.83 8.52384e+06 1.34454e+06 3.62478e+07
29264 20210716.10 6624.4 9.26721e+07 3351.62 1.80752e+08 24071.2 1.74367e+07 4470.54 1.50774e+07 2696.64 9.83456e+06 2361.41 9.04813e+06 1684.04 8.52384e+06 1.32918e+06 3.62478e+07
29304 20210719.2 6510.87 9.21478e+07 3284.19 1.82063e+08 20812.7 1.74367e+07 4380.68 1.56017e+07 2488.32 9.31027e+06 2576.74 1.32424e+07 1726.24 8.2617e+06 1.33743e+06 3.61837e+07
29365 20210720.2 6673.52 9.16235e+07 3236.53 1.9386e+08 23703.9 1.74367e+07 4200.39 1.50774e+07 2560.33 1.14074e+07 2367.52 9.57242e+06 1752.41 8.52384e+06 1.36442e+06 3.59298e+07
29366 20210720.3 6273.52 9.16235e+07 3245.95 2.05918e+08 23019.5 1.74367e+07 4216.69 1.4291e+07 2527.32 9.57242e+06 2513.24 9.31027e+06 1743.55 8.52384e+06 1.34067e+06 3.58669e+07
29428 20210720.20 6705.17 9.18856e+07 3299.5 1.62927e+08 23026.5 1.74367e+07 4456.17 1.48153e+07 2696.48 9.57242e+06 2448.57 9.04813e+06 1784.04 8.2617e+06 1.32608e+06 3.61837e+07
29468 20210720.30 6258.52 9.18856e+07 3026.74 2.10113e+08 23325.9 1.71746e+07 4222.13 1.53396e+07 2551.88 9.57242e+06 2602.16 1.21939e+07 1732.41 8.52384e+06 1.34277e+06 3.53713e+07
29478 20210721.1 6523.44 9.21478e+07 3276.24 1.70267e+08 21377.7 1.76989e+07 4434.02 1.45532e+07 2641.24 9.57242e+06 2584.28 9.83456e+06 1731.25 8.52384e+06 1.34524e+06 3.61199e+07
29513 20210721.12 6721.4 9.26721e+07 3418.56 1.82063e+08 23269.1 1.76989e+07 4497.91 1.48153e+07 2584.05 9.83456e+06 2492.67 9.31027e+06 1790.22 8.52384e+06 1.31746e+06 3.61837e+07
29526 20210721.16 6426.8 9.13613e+07 3258.64 1.56373e+08 24015.1 1.76989e+07 4430.9 1.48153e+07 2683.48 9.83456e+06 2610.85 9.31027e+06 1740.68 8.52384e+06 1.33638e+06 3.59298e+07
29539 20210721.20 6521.75 9.26721e+07 3251.31 1.68956e+08 23131.8 1.74367e+07 4433.65 1.48153e+07 2652.35 1.2456e+07 2508.62 9.57242e+06 1734.02 8.52384e+06 1.3342e+06 3.62478e+07

images

@achamayou achamayou merged commit 7d5954b into microsoft:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants