Release fix: Move consenus_type
check to where it is now defined
#2829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved
consensus_type
in #2780, from a top-level argument to nested within the passed config.This broke compilation, which tries to access an undefined variable, but only when
ENABLE_BFT=OFF
, which only happens in the release job. We should think about adding a regular build configuration which tests this flag, since every other build currently usesENABLE_BFT=ON
(and then runs tests on that BFT build).