Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL3: remove use of deprecated functions #5481

Merged
merged 77 commits into from
Aug 22, 2023

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Jul 28, 2023

Addresses #5291

One the main changes is that we now use OpenSSL3 for SGX builds (controlled via USE_OPENSSL_3 CMake flag).

The main performance drop in the JWT tests will be addressed by #5557.

Flamegraphs
ls_virtual_cft_openssl1
ls_virtual_cft_openssl3
ls_jwt_virtual_cft_openssl1
ls_jwt_virtual_cft_openssl3

@jumaffre jumaffre marked this pull request as ready for review August 21, 2023 09:48
@jumaffre jumaffre added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Aug 21, 2023
@jumaffre jumaffre changed the title OpenSSL3: remove use of most deprecated functions OpenSSL3: remove use of deprecated functions Aug 21, 2023
@achamayou
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jumaffre jumaffre merged commit 8aa778c into microsoft:main Aug 22, 2023
19 checks passed
@ghost
Copy link

ghost commented Aug 22, 2023

💔 All backports failed

Status Branch Result
release/4.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 5481

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@ghost ghost mentioned this pull request Aug 23, 2023
jumaffre added a commit to jumaffre/CCF that referenced this pull request Sep 8, 2023
(cherry picked from commit 8aa778c)

# Conflicts:
#	CHANGELOG.md
#	cmake/open_enclave.cmake
#	src/crypto/openssl/rsa_key_pair.cpp
#	src/crypto/openssl/rsa_public_key.cpp
@jumaffre jumaffre added the backported This PR was successfully backported to LTS branch label Sep 8, 2023
jumaffre added a commit that referenced this pull request Sep 11, 2023
…ns (#5481) (#5637)

Co-authored-by: Julien Maffre <jumaffre@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants