Update CCF to 4.0.12 and add support for OpenSSL 3.x #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andpiccione
commented
Jan 8, 2024
andpiccione
commented
- Update CCF version to 4.0.12
- Fix unit tests after crypto library changes introduced in CCF 4.0.8 (due to the upgrade to OpenSSL 3.x)
- Remove deprecated OpenSSL functions and add support for using OpenSSL 3.x in SGX builds based on CCF code changes
vimauro
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Overall LGTM ! I took a look at CCF code as well to validate their changes.
Only a minor comment about the usage of this condition if !(defined(OPENSSL_VERSION_MAJOR) && OPENSSL_VERSION_MAJOR >= 3) . My personal preference (and only cosmetic afterall) is to invert the if-else conditions and use if defined(OPENSSL_VERSION_MAJOR) && OPENSSL_VERSION_MAJOR >= 3
vimauro
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.