Add 'EnableDefaultCustomTypeMappings' switch #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Saves 586 KB on .NET 9, as a baseline (!!!):
|
Sergio0694
force-pushed
the
user/sergiopedri/default-mappings-switch
branch
from
7ccc47c
to
a104cc2
Compare
|
Updated diff with the default always-on mappings, and the extra guard code, 583 KB saved on .NET 9:
|
This was referenced Jan 31, 2024
manodasanW
reviewed
Feb 2, 2024
manodasanW
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a fair amount of binary size being used up due to all the default ABI type mappings from
Projections's type initializer, which ends up rooting a whole lot of stuff even if not actually used. This PR adds a newCsWinRTEnableDefaultCustomTypeMappingsproperty (defaults totrueto keep the current behavior), which allows developers to disable this behavior and trim all of that additional infrastructure. We should evaluate the best way to allow devs to then manually register the individual types they need. That could be via some newRegisterAbiTypeMapping-like methods or something.sizoscope diff incoming...