Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove almost all LINQ uses #1486

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Jan 31, 2024

This PR removes all LINQ uses (except one ToArray() call) from CsWinRT. It leaves the use in the NS2.0 projections and in a couple of custom mapping types that are now optional, meaning they're already pay-for play anyway, so that's fine.

@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/remove-linq2 branch 2 times, most recently from ff7d4a2 to c0dbc40 Compare January 31, 2024 23:51
@Sergio0694
Copy link
Member Author

Saves 15 KB:

image

Base automatically changed from user/sergiopedri/default-mappings-switch to staging/AOT February 2, 2024 19:17
@Sergio0694 Sergio0694 marked this pull request as ready for review February 2, 2024 19:20
@Sergio0694 Sergio0694 merged commit 65b086e into staging/AOT Feb 3, 2024
9 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/remove-linq2 branch February 3, 2024 17:12
Gaoyifei1011 added a commit to Gaoyifei1011/GetStoreApp that referenced this pull request Feb 6, 2024
…nRT#1486)

1.Remove all LINQ dependencies(Follow CsWinRT AOT branch microsoft/CsWinRT#1486)
2.Fixed an issue where the app crashed when a large number of download tasks were added and the download page opened
3.Update Microsoft.Windows.CsWinRT to 2.0.6
4.Update Microsoft.WindowsAppSDK to 1.5.240124002-experimental2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants