Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DXIL] Null pointer exception due to double floating-point literals in fmod intrinsic (in 1.8.2403 release) #6419

Closed
damyanp opened this issue Mar 14, 2024 · 1 comment · Fixed by #6418
Closed

[DXIL] Null pointer exception due to double floating-point literals in fmod intrinsic (in 1.8.2403 release) #6419

damyanp opened this issue Mar 14, 2024 · 1 comment · Fixed by #6418
Assignees
@tex3d
Labels
rca Candidate for a root cause analysis discussion sm6.8 Shader Model 6.8
Milestone
Release 1.8.2403.1

Comments

@damyanp
Copy link
Member

damyanp commented Mar 14, 2024

This issue tracks #6410, but specifically in the release branch. See the main issue for full information.
@damyanp damyanp added this to the Release 1.8.2403.1 milestone Mar 14, 2024
@damyanp damyanp linked a pull request Mar 14, 2024 that will close this issue
Revert "Fix crash in DXIL.dll caused by illegal DXIL intrinsic. (#6302) (#6342)" #6418
Merged
@damyanp damyanp mentioned this issue Mar 14, 2024
Closed
@github-project-automation github-project-automation bot moved this to 🆕 New in HLSL Roadmap Mar 14, 2024
@damyanp damyanp moved this from 🆕 New to 🏗 In progress in HLSL Roadmap Mar 14, 2024
@tex3d tex3d mentioned this issue Mar 14, 2024
Merged
tex3d added a commit that referenced this issue Mar 14, 2024
@tex3d
Revert "Fix crash in DXIL.dll caused by illegal DXIL intrinsic. (#6302)…
11ee8de 
… (#6342)" (#6418)

This file deleted with conflicts from subsequent changes:
  tools/clang/test/LitDXILValidation/illegalDXILOp.ll

This reverts commit 487080f.

Fixes #6419.
@damyanp damyanp added the rca Candidate for a root cause analysis discussion label Mar 15, 2024
@tex3d tex3d mentioned this issue Mar 20, 2024
Merged
tex3d added a commit that referenced this issue Mar 21, 2024
@tex3d
Add tests for literal overloads of fmod, length, and normalize (#6437)
9c2b828 
Certain HL ops with no double overload will generate double overloads
for literal types. These are lowered to double DXIL overloads, some of
which are not legal for these ops. We currently rely on illegal
intermediate DXIL op overloads for constant evaluation. If constant
evaluation fails, we end up with illegal DXIL overloads in final DXIL,
which is caught by the validator.

The prior revert restored the ability to run these scenarios (with
asserts disabled).

This change adds tests for #6419 so automated testing will test across
configurations and prevent regressions of this scenario in this branch.
@damyanp
Copy link
Member Author

damyanp commented Mar 22, 2024

Fixed by #6418

@damyanp damyanp closed this as completed Mar 22, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in HLSL Roadmap Mar 22, 2024
@pow2clk pow2clk added the sm6.8 Shader Model 6.8 label Mar 28, 2024
pow2clk pushed a commit to pow2clk/DirectXShaderCompiler that referenced this issue Jul 17, 2024
@tex3d @pow2clk
Add tests for literal overloads of fmod, length, and normalize (micro…
ab2eeda 
…soft#6437)

Certain HL ops with no double overload will generate double overloads
for literal types. These are lowered to double DXIL overloads, some of
which are not legal for these ops. We currently rely on illegal
intermediate DXIL op overloads for constant evaluation. If constant
evaluation fails, we end up with illegal DXIL overloads in final DXIL,
which is caught by the validator.

The prior revert restored the ability to run these scenarios (with
asserts disabled).

This change adds tests for microsoft#6419 so automated testing will test across
configurations and prevent regressions of this scenario in this branch.

(cherry picked from commit 9c2b828)
@pow2clk pow2clk mentioned this issue Jul 17, 2024
Merged
pow2clk added a commit that referenced this issue Jul 17, 2024
@pow2clk @tex3d
Add tests for literal overloads of fmod, length, and normalize (#6437) (
cfc8ba0 
#6799)

Certain HL ops with no double overload will generate double overloads
for literal types. These are lowered to double DXIL overloads, some of
which are not legal for these ops. We currently rely on illegal
intermediate DXIL op overloads for constant evaluation. If constant
evaluation fails, we end up with illegal DXIL overloads in final DXIL,
which is caught by the validator.

The prior revert restored the ability to run these scenarios (with
asserts disabled).

This change adds tests for #6419 so automated testing will test across
configurations and prevent regressions of this scenario in this branch.

(cherry picked from commit 9c2b828)

Co-authored-by: Tex Riddell <texr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tex3d tex3d

Labels
rca Candidate for a root cause analysis discussion sm6.8 Shader Model 6.8
Projects
HLSL Roadmap
Archived in project
Milestone
Release 1.8.2403.1
3 participants
@tex3d @damyanp @pow2clk