Add tests for literal overloads of fmod, length, and normalize (#6437) #6799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soft#6437) Certain HL ops with no double overload will generate double overloads for literal types. These are lowered to double DXIL overloads, some of which are not legal for these ops. We currently rely on illegal intermediate DXIL op overloads for constant evaluation. If constant evaluation fails, we end up with illegal DXIL overloads in final DXIL, which is caught by the validator. The prior revert restored the ability to run these scenarios (with asserts disabled). This change adds tests for microsoft#6419 so automated testing will test across configurations and prevent regressions of this scenario in this branch. (cherry picked from commit 9c2b828)
tex3d
approved these changes
Jul 17, 2024
damyanp
approved these changes
Jul 17, 2024
pow2clk
merged commit cfc8ba0
into
microsoft:release-preview-mesh-nodes
13 checks passed
python3kgae
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain HL ops with no double overload will generate double overloads for literal types. These are lowered to double DXIL overloads, some of which are not legal for these ops. We currently rely on illegal intermediate DXIL op overloads for constant evaluation. If constant evaluation fails, we end up with illegal DXIL overloads in final DXIL, which is caught by the validator.
The prior revert restored the ability to run these scenarios (with asserts disabled).
This change adds tests for #6419 so automated testing will test across configurations and prevent regressions of this scenario in this branch.
(cherry picked from commit 9c2b828)