-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Open source the implementation of dxil.dll. #6808
Comments
Merged
python3kgae
added a commit
that referenced
this issue
Aug 7, 2024
This pull request introduces the open-source implementation of hashing functionality for DXIL containers. DxilHash.cpp: Implements DXBC/DXIL container hashing functions. This is first part for #6808
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Open source the implementation of dxil.dll for open-sourcing-dxil-validator-hash
Describe the solution you'd like
Implement the solution in two steps:
Refactor the validator to a static library.
Open source dxil.dll with the static library validator.
Describe alternatives you've considered
An alternative approach is to open source dxil.dll first and then refactor. However, this would require refactoring the validator code twice.
Context
Open sourcing dxil.dll will introduce another validator to the repository, causing duplication with the existing validator. Refactoring the validator to a static library and sharing the code will eliminate this duplication. However, we cannot introduce new code with style issues into the repository. Therefore, refactoring should be done first, followed by open sourcing dxil.dll.
The text was updated successfully, but these errors were encountered: