Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Integrate container hash functionality into internal validator #6857

Closed
python3kgae opened this issue Aug 12, 2024 · 0 comments · Fixed by #6853
Closed
Labels
enhancement Feature suggestion
Milestone

Comments

@python3kgae
Copy link
Contributor

Is your feature request related to a problem? Please describe.
With validation hash open sourced at 84f68ed.
The internal validator could have the ability to do the validation hash work.
This will help cases where the compiling and hashing need to be in separate step when dxil.dll cannot find.

Describe the solution you'd like
Internal validator and external validator will share the same code which do the validation hash.

Describe alternatives you've considered
Remove dxil.dll and perform only the validation hash in dxc.
This change will cause use cases that require only dxil.dll to stop working.

Additional context
dxil.dll will be part of dxc repo (#6808)

@python3kgae python3kgae added enhancement Feature suggestion needs-triage Awaiting triage labels Aug 12, 2024
@damyanp damyanp added this to the Next Release milestone Aug 13, 2024
@damyanp damyanp removed the needs-triage Awaiting triage label Aug 13, 2024
@damyanp damyanp moved this to Triaged in HLSL Triage Aug 13, 2024
python3kgae added a commit that referenced this issue Aug 16, 2024
The changes affect both the internal validator (used within the DXIL
compiler) and external validation tools. Now, by default, validator hash
is enabled for all validation processes.

#6863 was created for tracking the skip hash discussion.

This is second step for #6808.
Fixes #6857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature suggestion
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants