Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Open source the implementation of dxil.dll. #6808

Open
python3kgae opened this issue Jul 19, 2024 · 0 comments · May be fixed by #6904
Open

[Feature Request] Open source the implementation of dxil.dll. #6808

python3kgae opened this issue Jul 19, 2024 · 0 comments · May be fixed by #6904
Assignees
Labels
enhancement Feature suggestion
Milestone

Comments

@python3kgae
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Open source the implementation of dxil.dll for open-sourcing-dxil-validator-hash

Describe the solution you'd like
Implement the solution in two steps:

Refactor the validator to a static library.
Open source dxil.dll with the static library validator.

Describe alternatives you've considered
An alternative approach is to open source dxil.dll first and then refactor. However, this would require refactoring the validator code twice.

Context
Open sourcing dxil.dll will introduce another validator to the repository, causing duplication with the existing validator. Refactoring the validator to a static library and sharing the code will eliminate this duplication. However, we cannot introduce new code with style issues into the repository. Therefore, refactoring should be done first, followed by open sourcing dxil.dll.

@python3kgae python3kgae added enhancement Feature suggestion needs-triage Awaiting triage labels Jul 19, 2024
@llvm-beanz llvm-beanz added this to the Next-next 2024 Release milestone Jul 22, 2024
@llvm-beanz llvm-beanz removed the needs-triage Awaiting triage label Jul 22, 2024
python3kgae added a commit that referenced this issue Aug 7, 2024
This pull request introduces the open-source implementation of hashing
functionality for DXIL containers.

DxilHash.cpp: Implements DXBC/DXIL container hashing functions.

This is first part for #6808
python3kgae added a commit that referenced this issue Aug 16, 2024
The changes affect both the internal validator (used within the DXIL
compiler) and external validation tools. Now, by default, validator hash
is enabled for all validation processes.

#6863 was created for tracking the skip hash discussion.

This is second step for #6808.
Fixes #6857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature suggestion
Projects
Status: In progress
Status: Triaged
Development

Successfully merging a pull request may close this issue.

2 participants