Remove ComponentContext.documentId, Container.id

[agarwal-navin]

documentId is a Container level concept and should not be exposed via ComponentContext and ComponentRuntime.
Especially with detachedContainers, Components do not know (or should care) when the Container is attached and the documentId is not available before the Container is attached.

[ghost]

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

[vladsud]

Reactivating, as this topic popped up in recent discussions.

[vladsud]

@chensixx - any chance you can do an assessment here on how it's used and if it's possible to deprecate it?
I'd try to break it into smaller work items:

1. Remove it from packages/runtime, which means removal from ICotainerContext and client-api
2. Look at how Container.id is used and if it can be removed over time. Key usages I see (in priority order):

• Remove it from IContainer & Container public API
• branch in attributes - I think we can remove it, but need to double check how it's used.
• getVersion() call - would be great over time to move to using undefined here for same purposes
• telemetry, using docId - we really need it. I think that's fine to leave as is, so I'd keep it as is, at least for now.

[vladsud]

Moving to August with assumption that you (@chensixx) are not going to complete it this month. If it's not the case, please move it back :)

[chensixx]

After first attempt of removing document id, I found one instance that's blocking removal: In document.ts, used by flowContainer, used in SharedText. This is also related to issue #2915 so I will fix 2915 first

[chensixx]

@vladsud I have a PR that removes docId from IFluidDataStoreContext and IFluidDataStoreRuntime. is the next step removing docId from everywhere? Since you mentioned remove it from IContainer as well.

[vladsud]

@chensixx, any chance you can update this item with latest thinking / breakdown / ETA?
I want to have a better handle of the work remaining, and when we think it will be completed.

[markfields]

Marking as an Epic. This work is staged into many steps and will be long-running.

[chensixx]

the only 2 steps left should be 1. removing container.id and usages, 2. removing containerContext.id after 0.55 is released, then it will be done.
also as Vlad mentioned, we can transition getVersions() to using undefined

[markfields]

@chensixx Heads up - When you merge that PR this issue will close, but from your last comment it sounds like this issue should live on until the final removal is done.