Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ContainerRuntime.id and IContainerRuntime.id as deprected. remove usage in containerRuntime #8492

Merged
merged 13 commits into from
Dec 14, 2021
Merged

Mark ContainerRuntime.id and IContainerRuntime.id as deprected. remove usage in containerRuntime #8492

merged 13 commits into from
Dec 14, 2021

Conversation

chensixx
Copy link
Contributor

@chensixx chensixx commented Dec 8, 2021 •
edited
Loading

Part1 to Fixes #2903
mark id as deprecated in ContainerRuntime and IContainerRuntime. Removed one usage of id in containerRuntime
also a typo i stumbled upon

@github-actions github-actions bot requested a review from vladsud December 8, 2021 00:01
@github-actions github-actions bot added area: runtime Runtime related issues public api change Changes to a public API labels Dec 8, 2021
@github-actions github-actions bot added the area: loader Loader related issues label Dec 8, 2021
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Dec 8, 2021 •
edited
Loading

⯆ @fluid-example/bundle-size-tests: -3 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 169.56 KB 169.55 KB ⯆ -3 Bytes
map.js 47.2 KB 47.2 KB ■ No change
matrix.js 143.43 KB 143.43 KB ■ No change
odspDriver.js 186.55 KB 186.55 KB ■ No change
odspPrefetchSnapshot.js 41.28 KB 41.28 KB ■ No change
sharedString.js 164.24 KB 164.24 KB ■ No change
Total Size 784.94 KB 784.94 KB ⯆ -3 Bytes

Baseline commit: 40be918

Generated by 🚫 dangerJS against d7a1a62

@github-actions github-actions bot removed the public api change Changes to a public API label Dec 8, 2021
@chensixx chensixx changed the title Removing ContainerRuntime.id Mark ContainerRuntime.id and IContainerRuntime.id as deprected. remove usage in containerRuntime Dec 8, 2021
@chensixx chensixx marked this pull request as ready for review December 8, 2021 19:03
@chensixx chensixx requested review from a team as code owners December 8, 2021 19:22
@github-actions github-actions bot added the public api change Changes to a public API label Dec 8, 2021
@github-actions github-actions bot removed request for a team December 8, 2021 19:22
vladsud
vladsud reviewed Dec 9, 2021
View reviewed changes
api-report/map.api.md Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from vladsud December 9, 2021 19:28
@github-actions github-actions bot removed the area: loader Loader related issues label Dec 9, 2021
@github-actions github-actions bot removed the public api change Changes to a public API label Dec 9, 2021
@github-actions github-actions bot added the public api change Changes to a public API label Dec 14, 2021
@github-actions github-actions bot requested a review from vladsud December 14, 2021 18:18
@chensixx chensixx merged commit b390c19 into microsoft:main Dec 14, 2021
@chensixx chensixx mentioned this pull request Jan 20, 2022
Merged
@chensixx chensixx deleted the remove branch April 21, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler left review comments

@anthony-murphy anthony-murphy Awaiting requested review from anthony-murphy

@vladsud vladsud Awaiting requested review from vladsud

Assignees
No one assigned
Labels
area: runtime Runtime related issues public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ComponentContext.documentId, Container.id
4 participants
@chensixx @msfluid-bot @tylerbutler @vladsud